Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 11439212: Add server21 as updateserver (Closed)

Created:
Aug. 16, 2013, 12:32 p.m. by Felix Dahlke
Modified:
Nov. 12, 2013, 10:13 a.m.
Reviewers:
Wladimir Palant
Visibility:
Public.

Description

This adds server21 and an updateserver module, which it uses.

Patch Set 1 #

Total comments: 6

Patch Set 2 : Addressed issues #

Unified diffs Side-by-side diffs Delta from patch set Stats (+110 lines, -1 line) Patch
M Vagrantfile View 1 chunk +1 line, -0 lines 0 comments Download
M manifests/monitoringserver.pp View 1 chunk +2 lines, -1 line 0 comments Download
M manifests/nodes.pp View 1 chunk +1 line, -0 lines 0 comments Download
A manifests/updateserver.pp View 1 chunk +7 lines, -0 lines 0 comments Download
A modules/updateserver/files/adblockplusie/update.json View 1 chunk +1 line, -0 lines 0 comments Download
A modules/updateserver/files/logrotate View 1 chunk +11 lines, -0 lines 0 comments Download
A modules/updateserver/files/update.adblockplus.org View 1 1 chunk +25 lines, -0 lines 0 comments Download
A modules/updateserver/manifests/init.pp View 1 1 chunk +62 lines, -0 lines 0 comments Download

Messages

Total messages: 4
Felix Dahlke
Aug. 16, 2013, 12:33 p.m. (2013-08-16 12:33:33 UTC) #1
Wladimir Palant
LGTM, only nits below. http://codereview.adblockplus.org/11439212/diff/1/modules/updateserver/files/update.adblockplus.org File modules/updateserver/files/update.adblockplus.org (right): http://codereview.adblockplus.org/11439212/diff/1/modules/updateserver/files/update.adblockplus.org#newcode24 modules/updateserver/files/update.adblockplus.org:24: } Drop that? We don't ...
Aug. 16, 2013, 1:11 p.m. (2013-08-16 13:11:02 UTC) #2
Felix Dahlke
Uploaded a new patch set (already pushed). http://codereview.adblockplus.org/11439212/diff/1/modules/updateserver/files/update.adblockplus.org File modules/updateserver/files/update.adblockplus.org (right): http://codereview.adblockplus.org/11439212/diff/1/modules/updateserver/files/update.adblockplus.org#newcode24 modules/updateserver/files/update.adblockplus.org:24: } On ...
Aug. 16, 2013, 2:07 p.m. (2013-08-16 14:07:53 UTC) #3
Wladimir Palant
Aug. 16, 2013, 2:29 p.m. (2013-08-16 14:29:15 UTC) #4
LGTM

Powered by Google App Engine
This is Rietveld