build_release.py - Issue 11440031: Ignore errors from nmake, we expect some right now

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Unified Diff: build_release.py

Issue 11440031: Ignore errors from nmake, we expect some right now (Closed)

Patch Set: Created Aug. 9, 2013, 9:16 a.m.

Use n/p to move between diff chunks; N/P to move between comments.

Jump to:

Index: build_release.py

===================================================================

--- a/build_release.py

+++ b/build_release.py

@@ -48,6 +48,9 @@

installerParams = os.environ.copy()

installerParams["VERSION"] = version

-subprocess.check_call(["nmake", "/A"], env=installerParams, cwd=os.path.join(basedir, "installer"))

+try:

+ subprocess.check_call(["nmake", "/A"], env=installerParams, cwd=os.path.join(basedir, "installer"))

+except subprocess.CalledProcessError:

+ print("An error occurred during nmake, continuing anyway")

sign(os.path.join(basedir, "build", "ia32", "adblockplusie-%s-en-us-ia32.msi" % version),

os.path.join(basedir, "build", "x64", "adblockplusie-%s-en-us-x64.msi" % version))

« no previous file with comments | « no previous file | no next file » | no next file with comments »