Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 11440031: Ignore errors from nmake, we expect some right now (Closed)

Created:
Aug. 9, 2013, 9:16 a.m. by Felix Dahlke
Modified:
Aug. 15, 2013, 3:03 p.m.
Reviewers:
Eric, Wladimir Palant
Visibility:
Public.

Description

This change is already pushed. Right now, we always get this error when trying to build the installer: light -notidy -nologo -cultures:en-us -ext WixUIExtension -out ..\build\x64\adblockplusie-0.8.500-en-us-x64.msi ..\build\x64\adblockplusie-0.8.500.wixobj ..\build\custom_WixUI_InstallDir.wixobj -loc en-us.wxl C:\Users\fhd\Projects\adblockplusie\installer\adblockplusie.wxs(216) : error LGHT0204 : ICE80: This 32BitComponent AdblockPlus32.dll uses 64BitDirectory INSTALL FOLDER NMAKE : fatal error U1077: '"C:\Program Files (x86)\WiX Toolset v3.6\bin\light.EXE"' : return code '0xcc' Stop. However, it's still being build properly. Eric said this issue has already been addressed in an as of yet unreviewed change, but for now I added this workaround. We should definitely. @Eric: Can you link the review in question here? We should definitely do it

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -1 line) Patch
M build_release.py View 1 chunk +4 lines, -1 line 0 comments Download

Messages

Total messages: 3
Felix Dahlke
This change is already pushed. Right now, we always get this error when trying to ...
Aug. 9, 2013, 9:27 a.m. (2013-08-09 09:27:03 UTC) #1
Wladimir Palant
IMHO this isn't the right approach. Note that I reverted your change in https://hg.adblockplus.org/adblockplusie/rev/990fe57c1ba9 - ...
Aug. 14, 2013, 6:27 a.m. (2013-08-14 06:27:32 UTC) #2
Felix Dahlke
Aug. 14, 2013, 6:36 a.m. (2013-08-14 06:36:35 UTC) #3
On 2013/08/14 06:27:32, Wladimir Palant wrote:
> IMHO this isn't the right approach. Note that I reverted your change in
> https://hg.adblockplus.org/adblockplusie/rev/990fe57c1ba9 - ignoring all
errors
> isn't great, we should only ignore the errors from a specific light command.
> nmake allows doing this by prefixing the command with a dash which is what I
> have done.

Ah, I wasn't sure how to do that, so I went for this blunt approach. I won't
miss it :)

Powered by Google App Engine
This is Rietveld