Prepared buildtools for Safari

Info.plist.tmpl

Index: Info.plist.tmpl
===================================================================
new file mode 100644
--- /dev/null
+++ b/Info.plist.tmpl
@@ -0,0 +1,139 @@
+<?xml version="1.0" encoding="UTF-8"?>
+<!DOCTYPE plist PUBLIC "-//Apple//DTD PLIST 1.0//EN" "http://www.apple.com/DTDs/PropertyList-1.0.dtd">
+<plist version="1.0">
+<dict>
+	<key>CFBundleDisplayName</key>

[Wladimir Palant, 2013/09/10 10:15:27]

Nit: We generally use two spaces for indentation, no tabs.

+	<string>{{ name }}</string>
+	<key>CFBundleIdentifier</key>
+	<string>{{ identifier }}</string>

[Wladimir Palant, 2013/09/10 10:15:27]

I suggest generating the identifier automatically rather than specifying it
explicitly:

  org.adblockplus.{{basename}}

[Sebastian Noack, 2013/09/10 12:40:43]

I assumed that the templates (or buildtools in general) shouldn't be too ABP
specific. If this isn't the case we could hard-code adblockplus here.

However wouldn't it supposed to be com.eyeo? As far as I know org isn't
dedicated to open source projects, but to non-profit organizations, which we
aren't.

[Wladimir Palant, 2013/09/10 14:02:12]

Well, we hardcode the devbuild URLs already so there is an inherent assumption
in buildtools that the extension will be hosted on adblockplus.org. We could
have an additional "id" field like in the Gecko metadata but there we have it
mostly for compatibility reasons - some extensions don't use the
foo@adblockplus.org ID scheme and we can no longer change that.
Why does it matter? adblockplus.org is where we do development.

Concerning the .org TLD you could read
http://en.wikipedia.org/wiki/.org#Registrations for example.

+	<key>CFBundleInfoDictionaryVersion</key>
+	<string>6.0</string>
+	<key>CFBundleShortVersionString</key>
+	<string>{{ version }}</string>

[Wladimir Palant, 2013/09/10 10:15:27]

According to Apple documentation we shouldn't be using the full version string
(including the build number) here. It should rather be metadata.get("general",
"version") here.

+	<key>CFBundleVersion</key>
+	<string>{{ version }}</string>
+	<key>Chrome</key>
+	<dict>
+		<key>Database Quota</key>
+		<real>104857600</real>
+		<key>Global Page</key>
+		<string>background.html</string>
+{%- if menus %}
+		<key>Menus</key>
+		<array>
+{%- for identifier, items in menus.iteritems() %}
+			<dict>
+				<key>Identifier</key>
+				<string>{{ identifier }}</string>
+				<key>Menu Items</key>
+				<array>
+{%- for identifier, props in items.iteritems() %}
+					<dict>
+						<key>Identifier</key>
+						<string>{{ identifier }}</string>
+{%- for key, value in props.iteritems() %}
+						<key>{{ key }}</key>
+						{{ value }}
+{%- endfor %}
+					</dict>
+{%- endfor %}
+				</array>
+			</dict>
+{%- endfor %}
+		</array>
+{%- endif %}
+{%- if popovers %}
+		<key>Popovers</key>
+		<array>
+{%- for identifier, props in popovers.iteritems() %}
+			<dict>
+				<key>Identifier</key>
+				<string>{{ identifier }}</string>
+{%- for key, value in props.iteritems() %}
+				<key>{{ key }}</key>
+				{{ value }}
+{%- endfor %}
+			</dict>
+{%- endfor %}
+		</array>
+{%- endif %}
+{%- if toolbarItems %}
+		<key>Toolbar Items</key>
+		<array>
+{%- for identifier, props in toolbarItems.iteritems() %}
+			<dict>
+				<key>Identifier</key>
+				<string>{{ identifier }}</string>
+{%- for key, value in props.iteritems() %}

[Wladimir Palant, 2013/09/10 10:15:27]

Having Jinja tags unindented makes the whole thing pretty hard to follow,
particularly for nested loops. How about using the same indentation approach as
in install.rdf.tmpl?

+				<key>{{ key }}</key>
+				{{ value }}
+{%- endfor %}
+			</dict>
+{%- endfor %}
+		</array>
+{%- endif %}
+	</dict>
+	<key>Content</key>
+	<dict>
+		<key>Scripts</key>
+		<dict>
+			<key>End</key>
+			<array>
+{%- for script in contentScripts.end %}
+				<string>{{ script }}</string>
+{%- endfor %}
+			</array>
+			<key>Start</key>
+			<array>
+{%- for script in contentScripts.start %}
+				<string>{{ script }}</string>
+{%- endfor %}
+			</array>
+		</dict>
+	</dict>
+	<key>ExtensionInfoDictionaryVersion</key>
+	<string>1.0</string>
+	<key>Permissions</key>
+	<dict>
+		<key>Website Access</key>
+		<dict>
+{%- if allowedDomains and not allowAllDomains %}
+			<key>Allowed Domains</key>
+			<array>
+{%- for domain in allowedDomains %}
+				<string>{{ domain }}</string>
+{%- endfor %}
+			</array>
+{%- endif %}
+			<key>Include Secure Pages</key>
+{%- if allowSecurePages %}
+			<true/>
+{%- else %}
+			<false/>
+{%- endif %}
+			<key>Level</key>
+{%- if allowAllDomains %}
+			<string>All</string>
+{%- elif allowedDomains %}
+			<string>Some</string>
+{%- else %}
+			<string>None</string>
+{%- endif %}
+		</dict>
+	</dict>
+	<key>Description</key>
+	<string>{{ description }}</string>
+{%- if author %}
+	<key>Author</key>
+	<string>{{ author }}</string>
+{%- endif %}
+{%- if website %}
+	<key>Website</key>
+	<string>{{ website }}</string>
+{%- endif %}
+{%- if updateURL %}
+	<key>Update Manifest URL</key>
+	<string>{{ updateURL }}</string>
+{%- endif %}

[Wladimir Palant, 2013/09/10 10:15:27]

There should always be an update URL for development builds, it also overwrites
the "regular" update URL. You should do it similarly to install.rdf.tmpl or
manifest.json.tmpl:

  {- if not releaseBuild or updateURL %}
  <key>Update Manifest URL</key>
  <string>
    {%- if not releaseBuild -%}
      https://adblockplus.org/devbuilds/
      {{- metadata.get('general', 'basename') -}}
      /updates.plist
    {%- else -%}
      {{ updateURL }}
    {%- endif -%}
  </string>
  {%- endif %}

+</dict>
+</plist>