Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 11577044: Switch to pygeoip for log processing to allow running it via PyPy (Closed)

Created:
Aug. 29, 2013, 7:38 p.m. by Wladimir Palant
Modified:
Aug. 29, 2013, 9:26 p.m.
Visibility:
Public.

Description

I added pygeoip to the repository to avoid complicating the dependencies. Now the log processing can be run via PyPy which speeds it up by 37% on my machine. Nice side-effect: IPv6 support (the <GeoIP version available for Ubuntu precise was too old for IPv6).

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2187 lines, -19 lines) Patch
A pygeoip/LICENSE.md View 1 chunk +165 lines, -0 lines 0 comments Download
A pygeoip/README.md View 1 chunk +95 lines, -0 lines 0 comments Download
A pygeoip/__init__.py View 1 chunk +668 lines, -0 lines 0 comments Download
A pygeoip/const.py View 1 chunk +431 lines, -0 lines 0 comments Download
A pygeoip/timezone.py View 1 chunk +760 lines, -0 lines 0 comments Download
A pygeoip/util.py View 1 chunk +36 lines, -0 lines 0 comments Download
M sitescripts/stats/bin/logprocessor.py View 6 chunks +15 lines, -10 lines 0 comments Download
M sitescripts/stats/test/logprocessor.py View 2 chunks +17 lines, -9 lines 0 comments Download

Messages

Total messages: 3
Wladimir Palant
Aug. 29, 2013, 7:38 p.m. (2013-08-29 19:38:45 UTC) #1
Sebastian Noack
lgtm
Aug. 29, 2013, 7:43 p.m. (2013-08-29 19:43:16 UTC) #2
Felix Dahlke
Aug. 29, 2013, 8:19 p.m. (2013-08-29 20:19:19 UTC) #3
LGTM!

Powered by Google App Engine
This is Rietveld