Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 11751005: Fix redirect blocking (http-on-modify-request notification fires delayed starting with Firefox 18) (Closed)

Created:
Sept. 13, 2013, 9:21 a.m. by Wladimir Palant
Modified:
Sept. 13, 2013, 10:19 a.m.
Reviewers:
Felix Dahlke
Visibility:
Public.

Description

Redirect handling is complicated, we can only see the HTTP channel there but not the additional data available in a content policy call. This means that we need to watch channel creation and to attach data from the preceding content policy call. The way to do that apparently changed in Firefox 18 (https://bugzilla.mozilla.org/show_bug.cgi?id=800799).

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -4 lines) Patch
M lib/contentPolicy.js View 3 chunks +11 lines, -4 lines 0 comments Download

Messages

Total messages: 2
Wladimir Palant
Sept. 13, 2013, 9:21 a.m. (2013-09-13 09:21:41 UTC) #1
Felix Dahlke
Sept. 13, 2013, 10:12 a.m. (2013-09-13 10:12:00 UTC) #2
LGTM

Powered by Google App Engine
This is Rietveld