Issue 12337020: Fixed: Handle console messages without source name for issue reporter

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 12337020: Fixed: Handle console messages without source name for issue reporter (Closed)

Created:
Oct. 4, 2013, 1:29 p.m. by Thomas Greiner

Modified:
Oct. 4, 2013, 1:44 p.m.

Reviewers:
Wladimir Palant

Visibility:
Public.

Description

There are console messages which don't have a source name associated to them (also mentioned at https://developer.mozilla.org/en-US/docs/XPCOM_Interface_Reference/nsIScriptError). This breaks the issue reporter (see https://adblockplus.org/forum/viewtopic.php?f=11&t=18260).

Patch Set 1 #

Created: Oct. 4, 2013, 1:29 p.m.

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	chrome/content/ui/sendReport.js	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 2

Expand All Messages | Collapse All Messages

Wladimir Palant

Oct. 4, 2013, 1:41 p.m. (2013-10-04 13:41:44 UTC) #2

LGTM but please update the same check in chrome/content/errors.html as well.

Expand All Messages | Collapse All Messages