Unified Diff: include/AdblockPlus/V8ValueHolder.h
Issue 12647002:
Fix memory leaks in libadblockplus (Closed)
Patch Set:
Created Oct. 6, 2013, 10:21 p.m.
Use n/p to move between diff chunks;
N/P to move between comments.
« no previous file with comments
|
« no previous file
|
src/FilterEngine.cpp » ('j')
|
src/FilterEngine.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')
| Index: include/AdblockPlus/V8ValueHolder.h |
| =================================================================== |
| --- a/include/AdblockPlus/V8ValueHolder.h |
| +++ b/include/AdblockPlus/V8ValueHolder.h |
| @@ -49,7 +49,14 @@ |
| { |
| reset(isolate, value); |
| } |
| - |
| + ~V8ValueHolder() |
| + { |
| + if (this->value.get()) |
| + { |
| + this->value->Dispose(this->isolate); |
| + this->value.reset(0); |
| + } |
|
Wladimir Palant
2013/10/08 08:12:19
Better avoid the code duplication here:
reset(0,
|
| + } |
| void reset(v8::Isolate* isolate, v8::Persistent<T> value) |
| { |
| if (this->value.get()) |
« no previous file with comments
|
« no previous file
|
src/FilterEngine.cpp » ('j')
|
src/FilterEngine.cpp » ('J')
