Fixed: String pref test failed due to default value differing across platforms

chrome/content/tests/prefs.js

 (function()
 {
   module("Preferences",
   {
     setup: function()
     {
       preparePrefs.call(this);
     },
 
     teardown: function()
@@ skipping 63 matching lines @@
     equal(Prefs.enabled, true, "Prefs object returns the correct value after setting pref to default value");
     equal(prefExists("enabled"), false, "User-defined pref has been removed");
     Prefs.enabled = false;
     equal(Prefs.enabled, false, "Prefs object returns the correct value after setting pref to non-default value");
     equal(prefExists("enabled"), true, "User-defined pref has been created");
     checkPref("enabled", false, "Value has been written");
   });
 
   test("String pref", function()
   {
-    Prefs.data_directory = "adblockplus";
-    equal(Prefs.data_directory, "adblockplus", "Prefs object returns the correct value after setting pref to default value");
-    equal(prefExists("data_directory"), false, "User-defined pref has been removed");
+    Prefs.notificationurl = "https://notification.adblockplus.org/notification.json";

[Wladimir Palant, 2013/10/10 12:16:29]

Please declare that value as a variable:

var defaultValue = "https://notification.adblockplus.org/notification.json";

It no longer is as simple as the other pref, so duplicating it wouldn't be
great.

+    equal(Prefs.notificationurl, "https://notification.adblockplus.org/notification.json", "Prefs object returns the correct value after setting pref to default value");
+    equal(prefExists("notificationurl"), false, "User-defined pref has been removed");
 
-    let newValue = "foo\u1234bar";
-    Prefs.data_directory = newValue;
-    equal(Prefs.data_directory, newValue, "Prefs object returns the correct value after setting pref to non-default value");
-    equal(prefExists("data_directory"), true, "User-defined pref has been created");
-    checkPref("data_directory", newValue, "Value has been written");
+    let newValue = "https://notification.adblockplus.org/foo\u1234bar.json";
+    Prefs.notificationurl = newValue;
+    equal(Prefs.notificationurl, newValue, "Prefs object returns the correct value after setting pref to non-default value");
+    equal(prefExists("notificationurl"), true, "User-defined pref has been created");
+    checkPref("notificationurl", newValue, "Value has been written");
   });
 
   test("Object pref (complete replacement)", function()
   {
     Prefs.notificationdata = {};
     deepEqual(Prefs.notificationdata, {}, "Prefs object returns the correct value after setting pref to default value");
     equal(prefExists("notificationdata"), false, "User-defined pref has been removed");
 
     let newValue = {foo:1, bar: "adsf\u1234"};
     Prefs.notificationdata = newValue;
@@ skipping 13 matching lines @@
     equal(prefExists("notificationdata"), true, "User-defined pref has been created");
     checkPref("notificationdata", {foo:1, bar: 2}, "Value has been written");
 
     delete Prefs.notificationdata.foo;
     delete Prefs.notificationdata.bar;
     Prefs.notificationdata = JSON.parse(JSON.stringify(Prefs.notificationdata));
     deepEqual(Prefs.notificationdata, {}, "Prefs object returns the correct value after setting pref to default value");
     equal(prefExists("notificationdata"), false, "User-defined pref has been removed");
   });
 })();