Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 12783007: Fixed: String pref test failed due to default value differing across platforms (Closed)

Created:
Oct. 10, 2013, 11:06 a.m. by Thomas Greiner
Modified:
Oct. 10, 2013, 12:29 p.m.
Reviewers:
Wladimir Palant
Visibility:
Public.

Description

I chose to go with notificationurl because it has to be the same value on Firefox, Chrome and Opera by design. Alternatively, I could've used subscriptions_exceptionsurl for this purpose.

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -8 lines) Patch
M chrome/content/tests/prefs.js View 1 chunk +8 lines, -8 lines 1 comment Download

Messages

Total messages: 2
Thomas Greiner
Oct. 10, 2013, 11:23 a.m. (2013-10-10 11:23:21 UTC) #1
Wladimir Palant
Oct. 10, 2013, 12:16 p.m. (2013-10-10 12:16:29 UTC) #2
LGTM with the nit addressed.

http://codereview.adblockplus.org/12783007/diff/1/chrome/content/tests/prefs.js
File chrome/content/tests/prefs.js (right):

http://codereview.adblockplus.org/12783007/diff/1/chrome/content/tests/prefs....
chrome/content/tests/prefs.js:84: Prefs.notificationurl =
"https://notification.adblockplus.org/notification.json";
Please declare that value as a variable:

var defaultValue = "https://notification.adblockplus.org/notification.json";

It no longer is as simple as the other pref, so duplicating it wouldn't be
great.

Powered by Google App Engine
This is Rietveld