Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 29317012: Issue 2681 - Fixed: Thunderbird 38 is listed twice on the requirements page (Closed)

Created:
June 15, 2015, 8:45 a.m. by Sebastian Noack
Modified:
June 15, 2015, 10:15 a.m.
Reviewers:
saroyanm
CC:
Wladimir Palant, kzar
Visibility:
Public.

Description

Issue 2681 - Fixed: Thunderbird 38 is listed twice on the requirements page

Patch Set 1 #

Total comments: 3
Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M globals/get_browser_versions.py View 1 chunk +1 line, -1 line 3 comments Download

Messages

Total messages: 4
Sebastian Noack
June 15, 2015, 8:46 a.m. (2015-06-15 08:46:56 UTC) #1
saroyanm
https://codereview.adblockplus.org/29317012/diff/29317013/globals/get_browser_versions.py File globals/get_browser_versions.py (right): https://codereview.adblockplus.org/29317012/diff/29317013/globals/get_browser_versions.py#newcode221 globals/get_browser_versions.py:221: set(versions['unreleased']) - set(re.sub(r'(\.0*)+$', '', ver) for ver in (current, ...
June 15, 2015, 9:35 a.m. (2015-06-15 09:35:25 UTC) #2
Sebastian Noack
https://codereview.adblockplus.org/29317012/diff/29317013/globals/get_browser_versions.py File globals/get_browser_versions.py (right): https://codereview.adblockplus.org/29317012/diff/29317013/globals/get_browser_versions.py#newcode221 globals/get_browser_versions.py:221: set(versions['unreleased']) - set(re.sub(r'(\.0*)+$', '', ver) for ver in (current, ...
June 15, 2015, 9:39 a.m. (2015-06-15 09:39:53 UTC) #3
saroyanm
June 15, 2015, 9:55 a.m. (2015-06-15 09:55:48 UTC) #4
https://codereview.adblockplus.org/29317012/diff/29317013/globals/get_browser...
File globals/get_browser_versions.py (right):

https://codereview.adblockplus.org/29317012/diff/29317013/globals/get_browser...
globals/get_browser_versions.py:221: set(versions['unreleased']) -
set(re.sub(r'(\.0*)+$', '', ver) for ver in (current, previous) if ver),
On 2015/06/15 09:39:53, Sebastian Noack wrote:
> On 2015/06/15 09:35:24, saroyanm wrote:
> > Why we always check for the re.sub(r'(\.0*) ? What about if the stable
version
> > will be Thunderbird 38.1 ?
> 
> The beta channel will be updated to 39, before 38.1 is going to be released.
> Though I agree that it would make sense to only consider the major number when
> excluding duplicates for Thunderbird. However, that won't work for other
> applications like Yandex.Browser.

LGTM

Powered by Google App Engine
This is Rietveld