globals/get_browser_versions.py - Issue 29317012: Issue 2681 - Fixed: Thunderbird 38 is listed twice on the requirements page

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Unified Diff: globals/get_browser_versions.py

Issue 29317012: Issue 2681 - Fixed: Thunderbird 38 is listed twice on the requirements page (Closed)

Patch Set: Created June 15, 2015, 8:45 a.m.

Use n/p to move between diff chunks; N/P to move between comments.

Jump to:

Index: globals/get_browser_versions.py

===================================================================

--- a/globals/get_browser_versions.py

+++ b/globals/get_browser_versions.py

@@ -218,7 +218,7 @@

# different channels are on the same version, but we want

# to list each version only once.

versions['unreleased'] = sorted(

- set(versions['unreleased']) - {current, previous},

+ set(versions['unreleased']) - set(re.sub(r'(\.0*)+$', '', ver) for ver in (current, previous) if ver),

saroyanm 2015/06/15 09:35:24 Why we always check for the re.sub(r'(\.0*) ? What

Sebastian Noack 2015/06/15 09:39:53 The beta channel will be updated to 39, before 38.

saroyanm 2015/06/15 09:55:48 LGTM

key=key_by_version

)

« no previous file with comments | « no previous file | no next file » | no next file with comments »