Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 29317030: Issue 2689 - Logic problem in BrowserAction._addChange (Closed)

Created:
June 17, 2015, 11:11 a.m. by tschuster
Modified:
Nov. 5, 2015, 10:57 a.m.
Reviewers:
Sebastian Noack
Visibility:
Public.

Description

Issue 2689 - Logic problem in BrowserAction._addChange

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -8 lines) Patch
M chrome/ext/background.js View 3 chunks +3 lines, -8 lines 1 comment Download

Messages

Total messages: 2
tschuster
June 17, 2015, 11:12 a.m. (2015-06-17 11:12:03 UTC) #1
Sebastian Noack
June 23, 2015, 9:46 a.m. (2015-06-23 09:46:36 UTC) #2
https://codereview.adblockplus.org/29317030/diff/29317031/chrome/ext/backgrou...
File chrome/ext/background.js (right):

https://codereview.adblockplus.org/29317030/diff/29317031/chrome/ext/backgrou...
chrome/ext/background.js:220: this._queueChanges();
This will call chrome.tabs.get() redundantly if multiple changes are added
synchronously (or just before _applyChanges is called). Frankly, I don't
understand the problem you try to fix here.

Powered by Google App Engine
This is Rietveld