Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(463)

Issue 29319002: Issue 1737 - ABP 1.3 for IE sometimes blocks navigation to the ad from Google search results

Can't Edit
Can't Publish+Mail
Start Review
Created:
4 years, 9 months ago by sergei
Modified:
4 years, 4 months ago
Reviewers:
Eric, Oleksandr
Visibility:
Public.

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -0 lines) Patch
M src/plugin/PluginClass.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/plugin/PluginClass.cpp View 1 chunk +5 lines, -0 lines 0 comments Download
M src/plugin/PluginWbPassThrough.cpp View 1 chunk +4 lines, -0 lines 1 comment Download

Messages

Total messages: 8
sergei
4 years, 9 months ago (2015-06-22 15:01:18 UTC) #1
Eric
I'd like to defer this issue to after the 1.5 release. This fix looks simple ...
4 years, 9 months ago (2015-06-25 19:01:32 UTC) #2
sergei
On 2015/06/25 19:01:32, Eric wrote: > I'd like to defer this issue to after the ...
4 years, 9 months ago (2015-06-26 14:55:43 UTC) #3
sergei
https://codereview.adblockplus.org/29319002/diff/29319003/src/plugin/PluginWbPassThrough.cpp File src/plugin/PluginWbPassThrough.cpp (right): https://codereview.adblockplus.org/29319002/diff/29319003/src/plugin/PluginWbPassThrough.cpp#newcode372 src/plugin/PluginWbPassThrough.cpp:372: m_contentType = ContentType::CONTENT_TYPE_DOCUMENT; If we decide to accept it, ...
4 years, 9 months ago (2015-06-30 15:44:55 UTC) #4
Oleksandr
On 2015/06/25 19:01:32, Eric wrote: > I've been working on for 'SetSite()' and 'CPluginClass' lifetime ...
4 years, 5 months ago (2015-10-26 11:35:00 UTC) #5
sergei
On 2015/10/26 11:35:00, Oleksandr wrote: > On 2015/06/25 19:01:32, Eric wrote: > > > I've ...
4 years, 5 months ago (2015-10-26 17:50:27 UTC) #6
Eric
On 2015/10/26 11:35:00, Oleksandr wrote: > Shall we revisit this change? I assume these are ...
4 years, 4 months ago (2015-11-18 17:23:30 UTC) #7
Oleksandr
4 years, 4 months ago (2015-11-20 03:03:01 UTC) #8
On 2015/10/26 17:50:27, sergei wrote:
> It seems such methods like
> `OnWindowStateChanged`, `OnBeforeNavigate2`, etc. are called from the same
> thread, within which `SetSite`is called.
--
> However, firstly, I would like to know the reason it's done exactly
> in `OnWindowStateChanged`. 

Unfortunately based on my tests a few years ago it could not guaranteed that
SetSite and OnWindowStateChanged would be called from the same thread. One edge
case would be to open many tabs, close IE and then reopen it so that it starts
reloading all those tabs simultaneously. In that case SetSite and
OnWindowStateChanged are not always synchronized. Another case is opening a tab
group. (In Favorites click on the -> arrow next to the folder). So whatever we
change here we'll need to make sure we don't break those edge cases.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 87257f5