Issue 2195 - Added notification opt-out (Platform)

options.js

 /*
  * This file is part of Adblock Plus <https://adblockplus.org/>,
  * Copyright (C) 2006-2015 Eyeo GmbH
  *
  * Adblock Plus is free software: you can redistribute it and/or modify
  * it under the terms of the GNU General Public License version 3 as
  * published by the Free Software Foundation.
  *
  * Adblock Plus is distributed in the hope that it will be useful,
  * but WITHOUT ANY WARRANTY; without even the implied warranty of
@@ skipping 69 matching lines @@
   if (Prefs.notifications_showui)
   {
     initCheckbox("shouldShowNotifications", {
       get: function()
       {
         return Prefs.notifications_ignoredcategories.indexOf("*") == -1;
       },
       toggle: function()
       {
         NotificationStorage.toggleIgnoreCategory("*");
-        return Prefs.notifications_ignoredcategories.indexOf("*") == -1;

[Sebastian Noack, 2015/06/25 13:55:04]

How about |this.get()| to avoid code duplication?

[Thomas Greiner, 2015/06/25 16:48:44]

Done.

+        return this.get();
       }
     });
   }
   else
     document.getElementById("shouldShowNotificationsContainer").hidden = true;
 
   ext.onMessage.addListener(onMessage);
 
   // Load recommended subscriptions
   loadRecommendations();
@@ skipping 563 matching lines @@
       links[i].href = arguments[i + 1];
       links[i].setAttribute("target", "_blank");
     }
     else if (typeof arguments[i + 1] == "function")
     {
       links[i].href = "javascript:void(0);";
       links[i].addEventListener("click", arguments[i + 1], false);
     }
   }
 }