Issue 2195 - Added notification opt-out (Platform)

Note that I duplicated the texts in this review since #2193 is still under review. As soon as that's done I'll create a new one to reuse the existing texts from the Firefox version.

[Sebastian Noack, 2015-06-25 13:55:04]

https://codereview.adblockplus.org/29321084/diff/29321085/notification.js
File notification.js (right):

https://codereview.adblockplus.org/29321084/diff/29321085/notification.js#new...
notification.js:126: break;
Nit: This break is redundant. But I leave it up to you whether to remove it.

https://codereview.adblockplus.org/29321084/diff/29321085/options.js
File options.js (right):

https://codereview.adblockplus.org/29321084/diff/29321085/options.js#newcode90
options.js:90: return Prefs.notifications_ignoredcategories.indexOf("*") == -1;
How about |this.get()| to avoid code duplication?

https://codereview.adblockplus.org/29321084/diff/29321085/skin/popup.css
File skin/popup.css (right):

https://codereview.adblockplus.org/29321084/diff/29321085/skin/popup.css#newc...
skin/popup.css:118: #notification:not(.closing) #notification-close-content
Isn't the |:not(.closing)| redundant here?

[Thomas Greiner, 2015-06-25 16:48:45]

Thanks for the quick response.

https://codereview.adblockplus.org/29321084/diff/29321085/notification.js
File notification.js (right):

https://codereview.adblockplus.org/29321084/diff/29321085/notification.js#new...
notification.js:126: break;
On 2015/06/25 13:55:04, Sebastian Noack wrote:
> Nit: This break is redundant. But I leave it up to you whether to remove it.

That's mainly a personal preference of mine to ensure that a break is only
missing if it was left out intentionally.

https://codereview.adblockplus.org/29321084/diff/29321085/options.js
File options.js (right):

https://codereview.adblockplus.org/29321084/diff/29321085/options.js#newcode90
options.js:90: return Prefs.notifications_ignoredcategories.indexOf("*") == -1;
On 2015/06/25 13:55:04, Sebastian Noack wrote:
> How about |this.get()| to avoid code duplication?

Done.

https://codereview.adblockplus.org/29321084/diff/29321085/skin/popup.css
File skin/popup.css (right):

https://codereview.adblockplus.org/29321084/diff/29321085/skin/popup.css#newc...
skin/popup.css:118: #notification:not(.closing) #notification-close-content
On 2015/06/25 13:55:04, Sebastian Noack wrote:
> Isn't the |:not(.closing)| redundant here?

No, because if #notification has the class "closing" then
#notification-close-content should not be hidden.

Basically, this selector acts like a toggle to show either #notification-content
if "closing" is set or #notification-close-content if it isn't. Here's an
alternative way of writing it:

#notification.closing #notification-content,
#notification #notification-close-content
{
  display: none;
}

#notification.closing #notification-close-content
{
  display: inherit;
}

[Sebastian Noack, 2015-06-25 22:34:19]

LGTM