Issue 2381 - Added share overlay to options page

options.js

Index: options.js
===================================================================
--- a/options.js
+++ b/options.js
@@ -663,35 +663,45 @@
     }
   }
 
-  function updateShareLink()
+  function onShareLinkClick(e)
   {
-    ext.backgroundPage.sendMessage(
+    e.preventDefault();
+
+    getDocLink("share-general", function(link)
     {
-      type: "filters.blocked",
-      url: "https://platform.twitter.com/widgets/",
-      requestType: "SCRIPT",
-      docDomain: "adblockplus.org",
-      thirdParty: true
-    },
-    function(blocked)
-    {
-      // TODO: modify "share" link accordingly
+      openSharePopup(link);
     });
   }
 
-  function E(id)
+  function updateShareLink()

[saroyanm, 2015/09/08 17:33:49]

Shouldn't this implementation also be shared between scripts ?

[Thomas Greiner, 2015/09/23 14:03:05]

No, the difference is that on the first-run page we check for a specific
resource while here we check for all three of them.

The reason for that is that we still want to show the share overlay when someone
clicks on the Twitter button even if the Facebook script is blocked.

   {
-    return document.getElementById(id);
-  }
+    var shareResources = [
+      "https://facebook.com/plugins/like.php?",
+      "https://platform.twitter.com/widgets/",
+      "https://apis.google.com/se/0/_/+1/fastbutton?"
+    ];
+    var isAnyBlocked = false;
+    var checksRemaining = shareResources.length;
 
-  function getDocLink(link, callback)
-  {
-    ext.backgroundPage.sendMessage(
+    function onResult(isBlocked)
     {
-      type: "app.get",
-      what: "doclink",
-      link: link
-    }, callback);
+      isAnyBlocked |= isBlocked;
+      if (!--checksRemaining)
+      {
+        // Hide the share tab if a script on the share page would be blocked
+        var tab = E("tab-share");
+        if (isAnyBlocked)
+        {
+          tab.hidden = true;
+          tab.removeEventListener("click", onShareLinkClick, false);
+        }
+        else
+          tab.addEventListener("click", onShareLinkClick, false);
+      }
+    }
+
+    for (var i = 0; i < shareResources.length; i++)
+      checkShareResource(shareResources[i], onResult);
   }
 
   ext.onMessage.addListener(function(message)