Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 29321511: Issue 2766 - Remove underscores from DNS names (Closed)

Created:
July 9, 2015, 3 p.m. by mathias
Modified:
July 13, 2015, 6:30 a.m.
Reviewers:
Wladimir Palant
CC:
Felix Dahlke, Fred
Visibility:
Public.

Description

Note that this will cause the underscore versions to remain in /etc/hosts during rollout..

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -11 lines) Patch
M hiera/hosts.yaml View 1 chunk +11 lines, -11 lines 0 comments Download

Messages

Total messages: 3
mathias
July 9, 2015, 3 p.m. (2015-07-09 15:00:03 UTC) #1
Wladimir Palant
LGTM Please make sure to roll out on all hosts - otherwise somebody provisioning later ...
July 10, 2015, 9:13 p.m. (2015-07-10 21:13:05 UTC) #2
mathias
July 13, 2015, 6:30 a.m. (2015-07-13 06:30:34 UTC) #3
On 2015/07/10 21:13:05, Wladimir Palant wrote:
> LGTM
> 
> Please make sure to roll out on all hosts - otherwise somebody provisioning
> later will get this change as a "side-effect," that's everything but great.

Sure, will do. First we need to apply the same modifications to `infrastructure`
(it's not only hosts.yaml there) though.

Powered by Google App Engine
This is Rietveld