Issue 29321511: Issue 2766 - Remove underscores from DNS names

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 29321511: Issue 2766 - Remove underscores from DNS names (Closed)

Created:
July 9, 2015, 3 p.m. by mathias

Modified:
July 13, 2015, 6:30 a.m.

Reviewers:
Wladimir Palant

CC:
Felix Dahlke, Fred

Visibility:
Public.

Description

Note that this will cause the underscore versions to remain in /etc/hosts during rollout..

Patch Set 1 #

Created: July 9, 2015, 3 p.m.

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+11 lines, -11 lines)			Patch
	M	hiera/hosts.yaml	View		1 chunk	+11 lines, -11 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

Wladimir Palant

LGTM Please make sure to roll out on all hosts - otherwise somebody provisioning later ...

July 10, 2015, 9:13 p.m. (2015-07-10 21:13:05 UTC) #2

mathias

July 13, 2015, 6:30 a.m. (2015-07-13 06:30:34 UTC) #3

On 2015/07/10 21:13:05, Wladimir Palant wrote:
> LGTM
> 
> Please make sure to roll out on all hosts - otherwise somebody provisioning
> later will get this change as a "side-effect," that's everything but great.

Sure, will do. First we need to apply the same modifications to `infrastructure`
(it's not only hosts.yaml there) though.

Expand All Messages | Collapse All Messages