Issue 29322488: Issue 2376 - mockup causing error

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 29322488: Issue 2376 - mockup causing error (Closed)

Created:
July 15, 2015, 5:26 p.m. by saroyanm

Modified:
July 16, 2015, 10:15 a.m.

Reviewers:
Thomas Greiner

Visibility:
Public.

Description

Issue 2376 - parseFilters function in mockup return wrong object

Patch Set 2 : Fixed 80 char limit #

Created: July 15, 2015, 5:54 p.m.

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -2 lines)			Patch
	M	background.js	View	1	1 chunk	+4 lines, -2 lines	0 comments	Download

Messages

Total messages: 6

Expand All Messages | Collapse All Messages

Thomas Greiner

https://codereview.adblockplus.org/29322488/diff/29322489/background.js File background.js (right): https://codereview.adblockplus.org/29322488/diff/29322489/background.js#newcode179 background.js:179: text.split("\n").map(modules.filterClasses.Filter.fromText), errors: []}; Again, mind the 80 characters limit. ...

July 15, 2015, 5:52 p.m. (2015-07-15 17:52:51 UTC) #2

saroyanm

July 15, 2015, 5:56 p.m. (2015-07-15 17:56:57 UTC) #3

Thomas Greiner

LGTM It would be great if you could come up with a more descriptive commit ...

July 16, 2015, 10:09 a.m. (2015-07-16 10:09:41 UTC) #4

saroyanm

On 2015/07/16 10:09:41, Thomas Greiner wrote: > LGTM > > It would be great if ...

July 16, 2015, 10:10 a.m. (2015-07-16 10:10:43 UTC) #5

Thomas Greiner

July 16, 2015, 10:12 a.m. (2015-07-16 10:12:21 UTC) #6

On 2015/07/16 10:10:43, saroyanm wrote:
> On 2015/07/16 10:09:41, Thomas Greiner wrote:
> > LGTM
> > 
> > It would be great if you could come up with a more descriptive commit
message
> > than the one in the review title.
> 
> What about the one in the description ? 
> "parseFilters function in mockup return wrong object"

That one's fine if you replace "return" with "returns"

Expand All Messages | Collapse All Messages