Issue 2796 - Added DeveloperIdentifier to Info.plist for Safari 9

Issue 2796 - Added DeveloperIdentifier to Info.plist for Safari 9

[kzar, 2015-07-16 15:39:53]

https://codereview.adblockplus.org/29322519/diff/29322520/packagerSafari.py
File packagerSafari.py (right):

https://codereview.adblockplus.org/29322519/diff/29322520/packagerSafari.py#n...
packagerSafari.py:117: def get_certificates_and_key(keyfile):
Nit: Use camel case to match the other function names?

https://codereview.adblockplus.org/29322519/diff/29322520/packagerSafari.py#n...
packagerSafari.py:144: raise Exception('No safari developer certificate found in
chain')
Nit: Capitalise Safari?

[Sebastian Noack, 2015-07-16 15:50:48]

https://codereview.adblockplus.org/29322519/diff/29322520/packagerSafari.py
File packagerSafari.py (right):

https://codereview.adblockplus.org/29322519/diff/29322520/packagerSafari.py#n...
packagerSafari.py:117: def get_certificates_and_key(keyfile):
On 2015/07/16 15:39:53, kzar wrote:
> Nit: Use camel case to match the other function names?

I think we should move to PEP-8 for new code.

https://codereview.adblockplus.org/29322519/diff/29322520/packagerSafari.py#n...
packagerSafari.py:144: raise Exception('No safari developer certificate found in
chain')
On 2015/07/16 15:39:53, kzar wrote:
> Nit: Capitalise Safari?

This code where merely copied from sitescripts. But yeah, I agree.

[kzar, 2015-07-16 15:56:35]

https://codereview.adblockplus.org/29322519/diff/29322520/packagerSafari.py
File packagerSafari.py (right):

https://codereview.adblockplus.org/29322519/diff/29322520/packagerSafari.py#n...
packagerSafari.py:117: def get_certificates_and_key(keyfile):
On 2015/07/16 15:50:48, Sebastian Noack wrote:
> On 2015/07/16 15:39:53, kzar wrote:
> > Nit: Use camel case to match the other function names?
> 
> I think we should move to PEP-8 for new code.

From PEP-8:

"A style guide is about consistency. Consistency with this style guide is
important. Consistency within a project is more important. Consistency within
one module or function is most important"

[Wladimir Palant, 2015-07-16 19:16:23]

https://codereview.adblockplus.org/29322519/diff/29322520/packagerSafari.py
File packagerSafari.py (right):

https://codereview.adblockplus.org/29322519/diff/29322520/packagerSafari.py#n...
packagerSafari.py:117: def get_certificates_and_key(keyfile):
I agree with Sebastian - we are never going to take the code and replace all
function names, we can only change the gradually whenever we change something.
It will be slightly inconsistent but IMHO that's a minor issue in this case.

https://codereview.adblockplus.org/29322519/diff/29322542/packagerSafari.py
File packagerSafari.py (right):

https://codereview.adblockplus.org/29322519/diff/29322542/packagerSafari.py#n...
packagerSafari.py:175: # write each certificate in DER format to a seperate
Nit: seperate => separate

[kzar, 2015-07-17 08:51:18]

https://codereview.adblockplus.org/29322519/diff/29322520/packagerSafari.py
File packagerSafari.py (right):

https://codereview.adblockplus.org/29322519/diff/29322520/packagerSafari.py#n...
packagerSafari.py:117: def get_certificates_and_key(keyfile):
On 2015/07/16 19:16:23, Wladimir Palant wrote:
> I agree with Sebastian - we are never going to take the code and replace all
> function names, we can only change the gradually whenever we change something.
> It will be slightly inconsistent but IMHO that's a minor issue in this case.

Acknowledged.

[Sebastian Noack, 2015-07-17 11:07:22]

https://codereview.adblockplus.org/29322519/diff/29322542/packagerSafari.py
File packagerSafari.py (right):

https://codereview.adblockplus.org/29322519/diff/29322542/packagerSafari.py#n...
packagerSafari.py:175: # write each certificate in DER format to a seperate
On 2015/07/16 19:16:23, Wladimir Palant wrote:
> Nit: seperate => separate

Done.

[Wladimir Palant, 2015-07-17 11:38:10]

LGTM