Issue 2797 - Add "Update From Gallery" key to the Safari extension update manifest

sitescripts/extensions/bin/createNightlies.py

 # coding: utf-8
 
 # This file is part of the Adblock Plus web scripts,
 # Copyright (C) 2006-2015 Eyeo GmbH
 #
 # Adblock Plus is free software: you can redistribute it and/or modify
 # it under the terms of the GNU General Public License version 3 as
 # published by the Free Software Foundation.
 #
 # Adblock Plus is distributed in the hope that it will be useful,
@@ skipping 179 matching lines @@
 
   def readSafariMetadata(self):
     import buildtools.packagerSafari as packager
     metadata = packager.readMetadata(self.tempdir, self.config.type)
     certs = packager.get_certificates_and_key(self.config.keyFile)[0]
 
     self.certificateID = packager.get_developer_identifier(certs)
     self.version = packager.getBuildVersion(self.tempdir, metadata, False, self.revision)
     self.shortVersion = metadata.get("general", "version")
     self.basename = metadata.get("general", "basename")
+    self.updatedFromGallery = True

[Wladimir Palant, 2015/07/16 19:13:26]

What's the point having a flag if it is a constant? Why not add this field to
the update manifest unconditionally?

[Sebastian Noack, 2015/07/17 11:08:45]

We use the same template to generate the update manifest for the devbuild, where
this option isn't supposed to be set.

[Sebastian Noack, 2015/07/17 11:34:52]

Argh, I just realized that I got it the wrong way around, adding the option for
devbuilds, but not for the stable channel. Fixed that.

 
   def writeUpdateManifest(self):
     """
       Writes update.rdf file for the current build
     """
     baseDir = os.path.join(self.config.nightliesDirectory, self.basename)
     if not os.path.exists(baseDir):
       os.makedirs(baseDir)
     if self.config.type == 'chrome' or self.config.type == 'opera':
       manifestPath = os.path.join(baseDir, "updates.xml")
@@ skipping 299 matching lines @@
     except Exception, ex:
       print >>sys.stderr, "The build for %s failed:" % repo
       traceback.print_exc()
 
   file = open(nightlyConfigFile, 'wb')
   nightlyConfig.write(file)
 
 
 if __name__ == '__main__':
   main()