Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code
Issues
All Issues

Issue 29322531: Issue 2797 - Add "Update From Gallery" key to the Safari extension update manifest (Closed)

Created:
July 16, 2015, 3:32 p.m. by Sebastian Noack
Modified:
July 17, 2015, 3:16 p.m.
Reviewers:
kzar, Wladimir Palant
Visibility:
Public.

Description

Issue 2797 - Add "Update From Gallery" key to the Safari extension update manifest

Patch Set 1 #

Total comments: 3

Patch Set 2 : Add "Update From Gallery" for stable, not development builds #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -0 lines) Patch
M sitescripts/extensions/bin/createNightlies.py View 1 1 chunk +1 line, -0 lines 0 comments Download
M sitescripts/extensions/bin/updateUpdateManifests.py View 1 1 chunk +1 line, -0 lines 0 comments Download
M sitescripts/extensions/template/updates.plist View 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 7
Sebastian Noack
July 16, 2015, 3:34 p.m. (2015-07-16 15:34:25 UTC) #1
kzar
LGTM
July 16, 2015, 3:54 p.m. (2015-07-16 15:54:44 UTC) #2
Wladimir Palant
https://codereview.adblockplus.org/29322531/diff/29322532/sitescripts/extensions/bin/createNightlies.py File sitescripts/extensions/bin/createNightlies.py (right): https://codereview.adblockplus.org/29322531/diff/29322532/sitescripts/extensions/bin/createNightlies.py#newcode200 sitescripts/extensions/bin/createNightlies.py:200: self.updatedFromGallery = True What's the point having a flag ...
July 16, 2015, 7:13 p.m. (2015-07-16 19:13:27 UTC) #3
Sebastian Noack
https://codereview.adblockplus.org/29322531/diff/29322532/sitescripts/extensions/bin/createNightlies.py File sitescripts/extensions/bin/createNightlies.py (right): https://codereview.adblockplus.org/29322531/diff/29322532/sitescripts/extensions/bin/createNightlies.py#newcode200 sitescripts/extensions/bin/createNightlies.py:200: self.updatedFromGallery = True On 2015/07/16 19:13:26, Wladimir Palant wrote: ...
July 17, 2015, 11:08 a.m. (2015-07-17 11:08:45 UTC) #4
Sebastian Noack
https://codereview.adblockplus.org/29322531/diff/29322532/sitescripts/extensions/bin/createNightlies.py File sitescripts/extensions/bin/createNightlies.py (right): https://codereview.adblockplus.org/29322531/diff/29322532/sitescripts/extensions/bin/createNightlies.py#newcode200 sitescripts/extensions/bin/createNightlies.py:200: self.updatedFromGallery = True On 2015/07/17 11:08:45, Sebastian Noack wrote: ...
July 17, 2015, 11:34 a.m. (2015-07-17 11:34:52 UTC) #5
Wladimir Palant
LGTM
July 17, 2015, 11:39 a.m. (2015-07-17 11:39:04 UTC) #6
kzar
July 17, 2015, 2:21 p.m. (2015-07-17 14:21:48 UTC) #7 
Even more LGTM

Powered by Google App Engine
This is Rietveld