Issue 1730 - Fixed abp:subscribe functionality with e10s

chrome/content/subscribeLinkHandler.js

+/*
+ * This file is part of Adblock Plus <https://adblockplus.org/>,
+ * Copyright (C) 2006-2015 Eyeo GmbH
+ *
+ * Adblock Plus is free software: you can redistribute it and/or modify
+ * it under the terms of the GNU General Public License version 3 as
+ * published by the Free Software Foundation.
+ *
+ * Adblock Plus is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+ * GNU General Public License for more details.
+ *
+ * You should have received a copy of the GNU General Public License
+ * along with Adblock Plus.  If not, see <http://www.gnu.org/licenses/>.
+ */
+
+(function()
+{
+  addEventListener("click", onClick, false);
+  addMessageListener("AdblockPlus:Shutdown", onShutdown);
+
+  function onShutdown(message)
+  {
+    if (message.data == Components.stack.filename)
+    {
+      removeEventListener("click", onClick, false);
+      removeMessageListener("AdblockPlus:Shutdown", onShutdown);
+    }
+  }
+
+  function onClick(event)
+  {
+    // Ignore right-clicks
+    if (event.button == 2)
+      return;
+
+    // Search the link associated with the click
+    let link = event.target;
+    while (!(link instanceof content.HTMLAnchorElement))

[Wladimir Palant, 2015/07/20 15:20:53]

The code in this function was only moved. The only changes are this line
(content.HTMLAnchorElement instead of Ci.nsIDOMHTMLAnchorElement) and sending
the message at the bottom.

+    {
+      link = link.parentNode;
+
+      if (!link)
+        return;
+    }
+
+    let queryString = null;
+    if (link.protocol == "http:" || link.protocol == "https:")
+    {
+      if (link.host == "subscribe.adblockplus.org" && link.pathname == "/")
+        queryString = link.search.substr(1);
+    }
+    else
+    {
+      // Firefox doesn't populate the "search" property for links with
+      // non-standard URL schemes so we need to extract the query string
+      // manually
+      let match = /^abp:\/*subscribe\/*\?(.*)/i.exec(link.href);
+      if (match)
+        queryString = match[1];
+    }
+
+    if (!queryString)
+      return;
+
+    // This is our link - make sure the browser doesn't handle it
+    event.preventDefault();
+    event.stopPropagation();
+
+    // Decode URL parameters
+    let title = null;
+    let url = null;
+    let mainSubscriptionTitle = null;
+    let mainSubscriptionURL = null;
+    for (let param of queryString.split("&"))
+    {
+      let parts = param.split("=", 2);
+      if (parts.length != 2 || !/\S/.test(parts[1]))
+        continue;
+      switch (parts[0])
+      {
+        case "title":
+          title = decodeURIComponent(parts[1]);
+          break;
+        case "location":
+          url = decodeURIComponent(parts[1]);
+          break;
+        case "requiresTitle":
+          mainSubscriptionTitle = decodeURIComponent(parts[1]);
+          break;
+        case "requiresLocation":
+          mainSubscriptionURL = decodeURIComponent(parts[1]);
+          break;
+      }
+    }
+
+    sendAsyncMessage("AdblockPlus:SubscribeLink", {
+      title: title,
+      url: url,
+      mainSubscriptionTitle: mainSubscriptionTitle,
+      mainSubscriptionURL: mainSubscriptionURL
+    });

[Thomas Greiner, 2015/07/21 09:54:03]

Detail: This can be simplified like this:

sendAsyncMessage("AdblockPlus:SubscribeLink", {title, url,
mainSubscriptionTitle, mainSubscriptionURL});

[Wladimir Palant, 2015/07/21 13:12:12]

Interesting. However, this is only supported starting with Firefox 34 - I don't
think this is worth changing compatibility info for. Also, Chrome doesn't
support this syntax at all meaning that this will be a hindrance should we
decide to merge the content scripts in future.

+  }
+})();
+