Issue 29322679: Issue 1730 - Fixed abp:subscribe functionality with e10s

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 29322679: Issue 1730 - Fixed abp:subscribe functionality with e10s (Closed)

Created:
July 20, 2015, 3:19 p.m. by Wladimir Palant

Modified:
July 21, 2015, 1:12 p.m.

Reviewers:
Thomas Greiner

Visibility:
Public.

Description

Issue 1730 - Fixed abp:subscribe functionality with e10s

Patch Set 1 #

Total comments: 3

Created: July 20, 2015, 3:19 p.m.

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+130 lines, -184 lines)			Patch
A	chrome/content/subscribeLinkHandler.js	View	1 chunk	+106 lines, -0 lines	3 comments	Download
M	lib/appSupport.js	View	4 chunks	+1 line, -111 lines	0 comments	Download
M	lib/ui.js	View	7 chunks	+23 lines, -71 lines	0 comments	Download
M	lib/utils.js	View	1 chunk	+0 lines, -2 lines	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

Wladimir Palant

https://codereview.adblockplus.org/29322679/diff/29322680/chrome/content/subscribeLinkHandler.js File chrome/content/subscribeLinkHandler.js (right): https://codereview.adblockplus.org/29322679/diff/29322680/chrome/content/subscribeLinkHandler.js#newcode40 chrome/content/subscribeLinkHandler.js:40: while (!(link instanceof content.HTMLAnchorElement)) The code in this function ...

July 20, 2015, 3:20 p.m. (2015-07-20 15:20:53 UTC) #2

Thomas Greiner

LGTM, just a small suggestion. https://codereview.adblockplus.org/29322679/diff/29322680/chrome/content/subscribeLinkHandler.js File chrome/content/subscribeLinkHandler.js (right): https://codereview.adblockplus.org/29322679/diff/29322680/chrome/content/subscribeLinkHandler.js#newcode103 chrome/content/subscribeLinkHandler.js:103: }); Detail: This can ...

July 21, 2015, 9:54 a.m. (2015-07-21 09:54:03 UTC) #3

Wladimir Palant

July 21, 2015, 1:12 p.m. (2015-07-21 13:12:12 UTC) #4

https://codereview.adblockplus.org/29322679/diff/29322680/chrome/content/subs...
File chrome/content/subscribeLinkHandler.js (right):

https://codereview.adblockplus.org/29322679/diff/29322680/chrome/content/subs...
chrome/content/subscribeLinkHandler.js:103: });
On 2015/07/21 09:54:03, Thomas Greiner wrote:
> Detail: This can be simplified like this:
> 
> sendAsyncMessage("AdblockPlus:SubscribeLink", {title, url,
> mainSubscriptionTitle, mainSubscriptionURL});

Interesting. However, this is only supported starting with Firefox 34 - I don't
think this is worth changing compatibility info for. Also, Chrome doesn't
support this syntax at all meaning that this will be a hindrance should we
decide to merge the content scripts in future.

Expand All Messages | Collapse All Messages