Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(76)

Issue 29323119: Issue 2839 - adjust templates for middle size screens (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
4 years, 6 months ago by saroyanm
Modified:
4 years, 6 months ago
Reviewers:
Thomas Greiner
CC:
Felix Dahlke
Visibility:
Public.

Description

Issue 2839 - adjust templates for middle size screens

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -10 lines) Patch
M includes/index.tmpl View 1 chunk +2 lines, -2 lines 1 comment Download
M pages/contribute.html View 1 chunk +2 lines, -2 lines 0 comments Download
M pages/features.html View 1 chunk +2 lines, -2 lines 0 comments Download
M templates/default.tmpl View 2 chunks +4 lines, -4 lines 1 comment Download

Messages

Total messages: 5
saroyanm
@Thomas can you please have a look. https://codereview.adblockplus.org/29323119/diff/29323120/templates/default.tmpl File templates/default.tmpl (left): https://codereview.adblockplus.org/29323119/diff/29323120/templates/default.tmpl#oldcode26 templates/default.tmpl:26: <link rel="stylesheet" ...
4 years, 6 months ago (2015-07-30 16:10:17 UTC) #1
Thomas Greiner
https://codereview.adblockplus.org/29323119/diff/29323120/includes/index.tmpl File includes/index.tmpl (left): https://codereview.adblockplus.org/29323119/diff/29323120/includes/index.tmpl#oldcode24 includes/index.tmpl:24: <link class="cssfx" href="/css/index-desktop.css" media="(min-width: 40.5em)" rel="stylesheet"> This value appears ...
4 years, 6 months ago (2015-07-31 15:25:47 UTC) #2
saroyanm
On 2015/07/31 15:25:47, Thomas Greiner wrote: > https://codereview.adblockplus.org/29323119/diff/29323120/includes/index.tmpl > File includes/index.tmpl (left): > > https://codereview.adblockplus.org/29323119/diff/29323120/includes/index.tmpl#oldcode24 ...
4 years, 6 months ago (2015-07-31 15:46:24 UTC) #3
saroyanm
On 2015/07/31 15:46:24, saroyanm wrote: > On 2015/07/31 15:25:47, Thomas Greiner wrote: > > https://codereview.adblockplus.org/29323119/diff/29323120/includes/index.tmpl ...
4 years, 6 months ago (2015-07-31 15:47:06 UTC) #4
Thomas Greiner
4 years, 6 months ago (2015-07-31 16:29:54 UTC) #5
LGTM
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 87257f5