Issue 2839 - adjust templates for middle size screens

Issue 2839 - adjust templates for middle size screens

[saroyanm, 2015-07-30 16:10:17]

@Thomas can you please have a look.

https://codereview.adblockplus.org/29323119/diff/29323120/templates/default.tmpl
File templates/default.tmpl (left):

https://codereview.adblockplus.org/29323119/diff/29323120/templates/default.t...
templates/default.tmpl:26: <link rel="stylesheet" href="/css/main-mobile.css"
media="screen and (max-width: 40.5em)">
I noticed that we are adjusting the layout for screen devices, but I think we
can make it consistent for desktop and screen devices, also considering that
fact that "desktop.css" files usually having conflicts with the "mobile.css"
when they both are loaded.

[Thomas Greiner, 2015-07-31 15:25:47]

https://codereview.adblockplus.org/29323119/diff/29323120/includes/index.tmpl
File includes/index.tmpl (left):

https://codereview.adblockplus.org/29323119/diff/29323120/includes/index.tmpl...
includes/index.tmpl:24: <link class="cssfx" href="/css/index-desktop.css"
media="(min-width: 40.5em)" rel="stylesheet">
This value appears to have been specifically chosen. Did you investigate the
reasoning behind that before changing it?

[saroyanm, 2015-07-31 15:46:24]

On 2015/07/31 15:25:47, Thomas Greiner wrote:
> https://codereview.adblockplus.org/29323119/diff/29323120/includes/index.tmpl
> File includes/index.tmpl (left):
> 
>
https://codereview.adblockplus.org/29323119/diff/29323120/includes/index.tmpl...
> includes/index.tmpl:24: <link class="cssfx" href="/css/index-desktop.css"
> media="(min-width: 40.5em)" rel="stylesheet">
> This value appears to have been specifically chosen. Did you investigate the
> reasoning behind that before changing it?

I initially googled for the value because I noticed it used quite often, it
seems to be standard for portrait size on tablets, but while our layout has
mostly width of 1000px I can't see reason of using this media query, while the
current layout and screen sizes smaller 1000px having bad user experience IMO.

[saroyanm, 2015-07-31 15:47:06]

On 2015/07/31 15:46:24, saroyanm wrote:
> On 2015/07/31 15:25:47, Thomas Greiner wrote:
> >
https://codereview.adblockplus.org/29323119/diff/29323120/includes/index.tmpl
> > File includes/index.tmpl (left):
> > 
> >
>
https://codereview.adblockplus.org/29323119/diff/29323120/includes/index.tmpl...
> > includes/index.tmpl:24: <link class="cssfx" href="/css/index-desktop.css"
> > media="(min-width: 40.5em)" rel="stylesheet">
> > This value appears to have been specifically chosen. Did you investigate the
> > reasoning behind that before changing it?
> 
> I initially googled for the value because I noticed it used quite often, it
> seems to be standard for portrait size on tablets, but while our layout has
> mostly width of 1000px I can't see reason of using this media query, while the
> current layout and screen sizes smaller 1000px having bad user experience IMO.

I mean current layout is not adjustable.

[Thomas Greiner, 2015-07-31 16:29:54]

LGTM