Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Unified Diff: 2

Issue 29325845: Restrict browser promotion to Firefox and Chrome (Closed)
Patch Set: Created Sept. 3, 2015, 3:53 p.m.
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: 2
===================================================================
--- a/2
+++ b/2
@@ -1,6 +1,6 @@
severity = information
-target = extension=adblockplus
-target = extension=adblockpluschrome
+target = extension=adblockplus application=firefox
+target = extension=adblockpluschrome application=chrome
Sebastian Noack 2015/09/03 16:10:29 So we don't want to show the notification on Opera
Felix Dahlke 2015/09/03 16:11:59 Doesn't seem worth the trouble, we didn't test thi
Sebastian Noack 2015/09/03 16:15:36 Yes, we have the opt-out on Safari. The UI is the
start = 2015-09-01T13:00
end = 2015-09-08T13:00
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld