metadata.common - Issue 29325973: Noissue - Apply YouTube workaround on Chrome (PLEASE REVERT ME!)

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Side by Side Diff: metadata.common

Issue 29325973: Noissue - Apply YouTube workaround on Chrome (PLEASE REVERT ME!) (Closed)

Patch Set: Created Sept. 5, 2015, 3:04 p.m.

Left:
Right:

Use n/p to move between diff chunks; N/P to move between comments.

Jump to:

View unified diff | Download patch

OLD	NEW
1 [general]	1 [general]

2 version = 1.9.2	2 version = 1.9.2

3 backgroundScripts = ext/common.js	3 backgroundScripts = ext/common.js

4 ext/background.js	4 ext/background.js

5 lib/compat.js	5 lib/compat.js

6 lib/info.js	6 lib/info.js

7 lib/adblockplus.js	7 lib/adblockplus.js

8 lib/punycode.js	8 lib/punycode.js

9 lib/publicSuffixList.js	9 lib/publicSuffixList.js

10 lib/sha1.js	10 lib/sha1.js

11 lib/jsbn.js	11 lib/jsbn.js

12 lib/rsa.js	12 lib/rsa.js

13 webrequest.js	13 webrequest.js

14 messageResponder.js	14 messageResponder.js

15 popupBlocker.js	15 popupBlocker.js

16 background.js	16 background.js

17 permissions = http:/// https:///	17 permissions = http:/// https:///

18	18

19 [contentScripts]	19 [contentScripts]

20 document_start = ext/common.js ext/content.js include.preload.js	20 document_start = ext/common.js ext/content.js include.preload.js include.youtube .js

21 document_end = include.postload.js	21 document_end = include.postload.js

22	22

23 [mapping]	23 [mapping]

24 ext/content.js = chrome/ext/content.js	24 ext/content.js = chrome/ext/content.js

25 ext/popup.js = chrome/ext/popup.js	25 ext/popup.js = chrome/ext/popup.js

	26 include.youtube.js = safari/include.youtube.js
	kzar 2015/09/05 15:17:26 Shouldn't this be added to metadata.chrome instead Shouldn't this be added to metadata.chrome instead of .common? (Or do you want to add this for Opera too?) Sebastian Noack 2015/09/05 15:21:14 Yes, Opera is presumably effected too, as this is Show quoted text On 2015/09/05 15:17:26, kzar wrote: > Shouldn't this be added to metadata.chrome instead of .common? (Or do you want > to add this for Opera too?) Yes, Opera is presumably effected too, as this is a Chromium bug. kzar 2015/09/05 15:22:57 Acknowledged. Show quoted text On 2015/09/05 15:21:14, Sebastian Noack wrote: > On 2015/09/05 15:17:26, kzar wrote: > > Shouldn't this be added to metadata.chrome instead of .common? (Or do you want > > to add this for Opera too?) > > Yes, Opera is presumably effected too, as this is a Chromium bug. Acknowledged.
26 subscriptions.xml = adblockplus/chrome/content/ui/subscriptions.xml	27 subscriptions.xml = adblockplus/chrome/content/ui/subscriptions.xml

27 firstRun.html = adblockplusui/firstRun.html	28 firstRun.html = adblockplusui/firstRun.html

28 firstRun.js = adblockplusui/firstRun.js	29 firstRun.js = adblockplusui/firstRun.js

29 i18n.js = adblockplusui/i18n.js	30 i18n.js = adblockplusui/i18n.js

30 messageResponder.js = adblockplusui/messageResponder.js	31 messageResponder.js = adblockplusui/messageResponder.js

31 icons/detailed/abp-128.png = adblockplusui/skin/abp-128.png	32 icons/detailed/abp-128.png = adblockplusui/skin/abp-128.png

32 skin/firstRun.css = adblockplusui/skin/firstRun.css	33 skin/firstRun.css = adblockplusui/skin/firstRun.css

33 skin/ajax-loader.gif = adblockplusui/skin/ajax-loader.gif	34 skin/ajax-loader.gif = adblockplusui/skin/ajax-loader.gif

34 skin/background.png = adblockplusui/skin/background.png	35 skin/background.png = adblockplusui/skin/background.png

35 skin/background-main.png = adblockplusui/skin/background-main.png	36 skin/background-main.png = adblockplusui/skin/background-main.png

(...skipping 72 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
108 addSubscription.label	109 addSubscription.label

109 addSubscriptionAdd.label	110 addSubscriptionAdd.label

110 addSubscriptionOther.label	111 addSubscriptionOther.label

111 acceptableAds2.label	112 acceptableAds2.label

112 viewList.label	113 viewList.label

113 readMore.label	114 readMore.label

114 adblockplus/chrome/locale/*/subscriptionSelection.dtd = location.label	115 adblockplus/chrome/locale/*/subscriptionSelection.dtd = location.label

115 title.label	116 title.label

116 adblockplus/chrome/locale/*/meta.properties = =name	117 adblockplus/chrome/locale/*/meta.properties = =name

117 adblockplusui/locale//firstRun.json = =	118 adblockplusui/locale//firstRun.json = =

OLD	NEW

« no previous file with comments | « no previous file | metadata.safari » ('j') | safari/include.youtube.js » ('J')