Noissue - Apply YouTube workaround on Chrome (PLEASE REVERT ME!)

This is a a quick and ugly hack to apply the workaround, we currently have on Safari, to remove ads from YouTube videos by messing with YT's JavaScript, also on Chrome.

Currently, for some users, ads aren't blocked in YouTube videos, due to a Chrome bug:
https://code.google.com/p/chromium/issues/detail?id=526413

All ad blockers are effected, and nobody has a workaround yet. So I'd like to offer one to our users for the time being.

I will take care to revert this change before the code freeze for the next release.

[kzar, 2015-09-05 15:17:26]

https://codereview.adblockplus.org/29325973/diff/29325974/metadata.common
File metadata.common (right):

https://codereview.adblockplus.org/29325973/diff/29325974/metadata.common#new...
metadata.common:26: include.youtube.js = safari/include.youtube.js
Shouldn't this be added to metadata.chrome instead of .common? (Or do you want
to add this for Opera too?)

https://codereview.adblockplus.org/29325973/diff/29325974/safari/include.yout...
File safari/include.youtube.js (right):

https://codereview.adblockplus.org/29325973/diff/29325974/safari/include.yout...
safari/include.youtube.js:22: if ("sendMessageSync" in ext.backgroundPage &&
!ext.backgroundPage.sendMessageSync({type: "get-domain-enabled-state"}).enabled)
Unrelated change?

[Sebastian Noack, 2015-09-05 15:21:14]

https://codereview.adblockplus.org/29325973/diff/29325974/metadata.common
File metadata.common (right):

https://codereview.adblockplus.org/29325973/diff/29325974/metadata.common#new...
metadata.common:26: include.youtube.js = safari/include.youtube.js
On 2015/09/05 15:17:26, kzar wrote:
> Shouldn't this be added to metadata.chrome instead of .common? (Or do you want
> to add this for Opera too?)

Yes, Opera is presumably effected too, as this is a Chromium bug.

https://codereview.adblockplus.org/29325973/diff/29325974/safari/include.yout...
File safari/include.youtube.js (right):

https://codereview.adblockplus.org/29325973/diff/29325974/safari/include.yout...
safari/include.youtube.js:22: if ("sendMessageSync" in ext.backgroundPage &&
!ext.backgroundPage.sendMessageSync({type: "get-domain-enabled-state"}).enabled)
On 2015/09/05 15:17:26, kzar wrote:
> Unrelated change?

Nope. Synchronous messaging is only available in Safari. Yes, that means this
code is also performed if Adblock Plus is disabled on YouTube.

[kzar, 2015-09-05 15:22:58]

LGTM

https://codereview.adblockplus.org/29325973/diff/29325974/metadata.common
File metadata.common (right):

https://codereview.adblockplus.org/29325973/diff/29325974/metadata.common#new...
metadata.common:26: include.youtube.js = safari/include.youtube.js
On 2015/09/05 15:21:14, Sebastian Noack wrote:
> On 2015/09/05 15:17:26, kzar wrote:
> > Shouldn't this be added to metadata.chrome instead of .common? (Or do you
want
> > to add this for Opera too?)
> 
> Yes, Opera is presumably effected too, as this is a Chromium bug.

Acknowledged.

https://codereview.adblockplus.org/29325973/diff/29325974/safari/include.yout...
File safari/include.youtube.js (right):

https://codereview.adblockplus.org/29325973/diff/29325974/safari/include.yout...
safari/include.youtube.js:22: if ("sendMessageSync" in ext.backgroundPage &&
!ext.backgroundPage.sendMessageSync({type: "get-domain-enabled-state"}).enabled)
On 2015/09/05 15:21:14, Sebastian Noack wrote:
> On 2015/09/05 15:17:26, kzar wrote:
> > Unrelated change?
> 
> Nope. Synchronous messaging is only available in Safari. Yes, that means this
> code is also performed if Adblock Plus is disabled on YouTube.

Acknowledged.

[Sebastian Noack, 2015-09-16 06:47:24]

Closing this review unmerged now. It turned out that this only happened with the
YouTube app from the Chrome Web Store installed. Since Chrome 45, the webRequest
API doesn't report requests initiated by other extensions anymore. However, due
to a bug, requests associated with apps were ignored as well. This has been
fixed now in upstream Chrome. And the fix got merged back to Chrome 45. Hence
this workaround isn't necessary anymore.