safari/include.youtube.js - Issue 29325973: Noissue - Apply YouTube workaround on Chrome (PLEASE REVERT ME!)

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Unified Diff: safari/include.youtube.js

Issue 29325973: Noissue - Apply YouTube workaround on Chrome (PLEASE REVERT ME!) (Closed)

Patch Set: Created Sept. 5, 2015, 3:04 p.m.

Use n/p to move between diff chunks; N/P to move between comments.

Jump to:

Index: safari/include.youtube.js

===================================================================

--- a/safari/include.youtube.js

+++ b/safari/include.youtube.js

@@ -19,7 +19,7 @@

if (document.domain != "www.youtube.com")

return;

- if (!ext.backgroundPage.sendMessageSync({type: "get-domain-enabled-state"}).enabled)

+ if ("sendMessageSync" in ext.backgroundPage && !ext.backgroundPage.sendMessageSync({type: "get-domain-enabled-state"}).enabled)

kzar 2015/09/05 15:17:26 Unrelated change?

Sebastian Noack 2015/09/05 15:21:14 Nope. Synchronous messaging is only available in S

kzar 2015/09/05 15:22:57 Acknowledged.

return;

« metadata.common ('K') | « metadata.safari ('k') | no next file » | no next file with comments »