sitescripts/subscriptions/subscriptionParser.py - Issue 29326068: Issue 2823 - Attach parent subscription types when parsing supplemental subscriptions

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Unified Diff: sitescripts/subscriptions/subscriptionParser.py

Issue 29326068: Issue 2823 - Attach parent subscription types when parsing supplemental subscriptions (Closed)

Patch Set: Created Sept. 8, 2015, 9:44 a.m.

Use n/p to move between diff chunks; N/P to move between comments.

Jump to:

Index: sitescripts/subscriptions/subscriptionParser.py

===================================================================

--- a/sitescripts/subscriptions/subscriptionParser.py

+++ b/sitescripts/subscriptions/subscriptionParser.py

@@ -45,6 +45,7 @@

unavailable = define_property("unavailable", readonly=True)

catchall = define_property("catchall", readonly=True)

supplements = define_property("supplements", readonly=True)

+ supplementsType = define_property("supplementsType", readonly=True)

supplemented = define_property("supplemented", readonly=True)

variants = define_property("variants", readonly=True)

homepage = define_property("homepage")

@@ -69,6 +70,7 @@

'unavailable': False,

'catchall': False,

'supplements': [],

+ 'supplementsType': set(),

'supplemented': [],

'variants': [],

'recommendation': None,

@@ -220,6 +222,7 @@

if supplements in lists:

if lists[supplements].type == filedata.type:

lists[supplements].supplemented.append(filedata)

+ filedata.supplementsType.add(lists[supplements].type)

else:

warn('Subscription %s supplements an unknown subscription %s' % (filedata.name, supplements))

« no previous file with comments | « no previous file | no next file » | no next file with comments »