Issue 29326068: Issue 2823 - Attach parent subscription types when parsing supplemental subscriptions

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 29326068: Issue 2823 - Attach parent subscription types when parsing supplemental subscriptions (Closed)

Created:
Sept. 8, 2015, 9:44 a.m. by Thomas Greiner

Modified:
Sept. 9, 2015, 12:13 p.m.

Reviewers:
Sebastian Noack

Visibility:
Public.

Description

This change turned out to be necessary to implement #2823 and thereby also fix #2994. I decided to introduce a new property to assure backwards compatibility. Let me know whether you prefer including the subscription objects instead of just their types in that property. See Website changes: https://codereview.adblockplus.org/29326085/

Patch Set 1 #

Created: Sept. 8, 2015, 9:44 a.m.

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -0 lines)			Patch
	M	sitescripts/subscriptions/subscriptionParser.py	View		3 chunks	+3 lines, -0 lines	0 comments	Download

Messages

Total messages: 2

Expand All Messages | Collapse All Messages

LGTM

Expand All Messages | Collapse All Messages