Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(438)

Issue 29326188: Issue 3039 - Generate qunit/index.html based on metadata (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
4 years, 4 months ago by kzar
Modified:
4 years, 4 months ago
Reviewers:
Sebastian Noack
Visibility:
Public.

Description

Issue 3039 - Generate qunit/index.html based on metadata

Patch Set 1 #

Patch Set 2 : Try again... #

Total comments: 2

Patch Set 3 : Avoid hardcoding "Adblock Plus", instead use basename #

Unified diffs Side-by-side diffs Delta from patch set Stats (+54 lines, -11 lines) Patch
M background.html.tmpl View 1 chunk +1 line, -1 line 0 comments Download
M packagerChrome.py View 1 2 2 chunks +11 lines, -0 lines 0 comments Download
M packagerSafari.py View 1 3 chunks +7 lines, -10 lines 0 comments Download
A testIndex.html.tmpl View 1 2 1 chunk +35 lines, -0 lines 0 comments Download

Messages

Total messages: 5
kzar
Patch Set 1
4 years, 4 months ago (2015-09-09 15:37:06 UTC) #1
kzar
Patch Set 2 : Try again...
4 years, 4 months ago (2015-09-09 15:51:45 UTC) #2
Sebastian Noack
Maybe we can make it even more generic. That you can configure it like that: ...
4 years, 4 months ago (2015-09-09 16:07:14 UTC) #3
kzar
Patch Set 3 : Avoid hardcoding "Adblock Plus", instead use basename I like your idea ...
4 years, 4 months ago (2015-09-09 16:31:12 UTC) #4
Sebastian Noack
4 years, 4 months ago (2015-09-09 16:54:26 UTC) #5
On 2015/09/09 16:31:12, kzar wrote:
> I like your idea for making this pattern completely generic but I think it's
> probably overkill for now. I think if we hit this pattern again we should
> definitely do it however.

I don't know. Hard to tell without seeing the resulting code. But I could
imagine that the implementation would actually be more straight-forward and not
much (if any) more complex. I leave it up to you whether to give it a shot or
not. Otherwise, LGTM.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 87257f5