Issue 29326188: Issue 3039 - Generate qunit/index.html based on metadata

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 29326188: Issue 3039 - Generate qunit/index.html based on metadata (Closed)

Created:
Sept. 9, 2015, 3:35 p.m. by kzar

Modified:
Sept. 9, 2015, 5:48 p.m.

Reviewers:
Sebastian Noack

Visibility:
Public.

Description

Issue 3039 - Generate qunit/index.html based on metadata

Patch Set 1 #

Patch Set 2 : Try again... #

Total comments: 2

Patch Set 3 : Avoid hardcoding "Adblock Plus", instead use basename #

Created: Sept. 9, 2015, 4:28 p.m.

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+54 lines, -11 lines)			Patch
M	background.html.tmpl	View		1 chunk	+1 line, -1 line	0 comments	Download
M	packagerChrome.py	View	1 2	2 chunks	+11 lines, -0 lines	0 comments	Download
M	packagerSafari.py	View	1	3 chunks	+7 lines, -10 lines	0 comments	Download
A	testIndex.html.tmpl	View	1 2	1 chunk	+35 lines, -0 lines	0 comments	Download

Messages

Total messages: 5

Expand All Messages | Collapse All Messages

Sebastian Noack

Maybe we can make it even more generic. That you can configure it like that: ...

Sept. 9, 2015, 4:07 p.m. (2015-09-09 16:07:14 UTC) #3

kzar

Patch Set 3 : Avoid hardcoding "Adblock Plus", instead use basename I like your idea ...

Sept. 9, 2015, 4:31 p.m. (2015-09-09 16:31:12 UTC) #4

Sebastian Noack

Sept. 9, 2015, 4:54 p.m. (2015-09-09 16:54:26 UTC) #5

On 2015/09/09 16:31:12, kzar wrote:
> I like your idea for making this pattern completely generic but I think it's
> probably overkill for now. I think if we hit this pattern again we should
> definitely do it however.

I don't know. Hard to tell without seeing the resulting code. But I could
imagine that the implementation would actually be more straight-forward and not
much (if any) more complex. I leave it up to you whether to give it a shot or
not. Otherwise, LGTM.

Expand All Messages | Collapse All Messages