Unified Diff: firstRun.html
Issue 29326238:
Issue 3031 - Add Adblock Browser section to First Run Page (Closed)
Patch Set: Removed block for French locale
Created Sept. 10, 2015, 9:55 a.m.
Use n/p to move between diff chunks;
N/P to move between comments.
« no previous file with comments
|
« no previous file
|
locale/en-US/firstRun.json » ('j')
|
skin/firstRun.css » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')
| Index: firstRun.html |
| =================================================================== |
| --- a/firstRun.html |
| +++ b/firstRun.html |
| @@ -39,9 +39,23 @@ |
| <section id="dataCorruptionWarning" class="i18n_firstRun_dataCorruptionWarning warning" hidden="true"></section> |
| <div id="content"> |
| - <section id="acceptable-ads"> |
| - <h2 class="i18n_firstRun_acceptableAdsHeadline"></h2> |
| - <p id="acceptableAdsExplanation" class="i18n_firstRun_acceptableAdsExplanation"></p> |
| + <section id="general"> |
| + <div id="acceptable-ads-block"> |
|
Thomas Greiner
2015/09/11 18:11:59
Detail: There's no need to change the ID of this e
saroyanm
2015/09/15 09:42:37
I tried to make the consistent, in the share secti
|
| + <h2 class="i18n_firstRun_acceptableAdsHeadline"></h2> |
| + <p id="acceptableAdsExplanation" class="i18n_firstRun_acceptableAdsExplanation"></p> |
|
Thomas Greiner
2015/09/11 18:11:59
Detail: Inconsistent naming of element IDs.
saroyanm
2015/09/15 09:42:37
I guess you mean the dashes separation ? Done. Ple
|
| + </div> |
| + <div id="abb-promotion-block"> |
| + <h2 class="i18n_firstRun_abbPromotionHeadline"></h2> |
| + <a href="https://adblockbrowser.org/?ref=frp"> |
| + <div> |
| + <img src="skin/abb-logo.png" alt="Adblock Browser logo" /> |
| + </div> |
| + <div> |
| + <div class="i18n_firstRun_abbButtonText1"></div> |
| + <div class="i18n_firstRun_abbButtonText2"></div> |
| + </div> |
| + </a> |
| + </div> |
| </section> |
« no previous file with comments
|
« no previous file
|
locale/en-US/firstRun.json » ('j')
|
skin/firstRun.css » ('J')
