Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 29327611: Issue 3056 - [cms] Enable threading for the test server (Closed)

Created:
Sept. 15, 2015, 6:32 a.m. by Sebastian Noack
Modified:
Sept. 16, 2015, 6:31 a.m.
Reviewers:
kzar, Wladimir Palant
Visibility:
Public.

Description

Issue 3056 - [cms] Enable threading for the test server

Patch Set 1 #

Total comments: 2

Patch Set 2 : Use daemon threads #

Patch Set 3 : Referred GitHub issue #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -4 lines) Patch
M cms/bin/test_server.py View 1 2 3 chunks +13 lines, -4 lines 0 comments Download

Messages

Total messages: 5
Sebastian Noack
Sept. 15, 2015, 6:33 a.m. (2015-09-15 06:33:15 UTC) #1
kzar
https://codereview.adblockplus.org/29327611/diff/29327612/cms/bin/test_server.py File cms/bin/test_server.py (right): https://codereview.adblockplus.org/29327611/diff/29327612/cms/bin/test_server.py#newcode142 cms/bin/test_server.py:142: class ThreadedWSGIServer(ThreadingMixIn, WSGIServer): Perhaps we should set the daemon_threads ...
Sept. 15, 2015, 8:41 a.m. (2015-09-15 08:41:41 UTC) #2
Sebastian Noack
https://codereview.adblockplus.org/29327611/diff/29327612/cms/bin/test_server.py File cms/bin/test_server.py (right): https://codereview.adblockplus.org/29327611/diff/29327612/cms/bin/test_server.py#newcode142 cms/bin/test_server.py:142: class ThreadedWSGIServer(ThreadingMixIn, WSGIServer): On 2015/09/15 08:41:41, kzar wrote: > ...
Sept. 15, 2015, 3:23 p.m. (2015-09-15 15:23:13 UTC) #3
kzar
LGTM
Sept. 15, 2015, 3:35 p.m. (2015-09-15 15:35:41 UTC) #4
Wladimir Palant
Sept. 15, 2015, 11:11 p.m. (2015-09-15 23:11:21 UTC) #5
LGTM

Powered by Google App Engine
This is Rietveld