Issue 3056 - [cms] Enable threading for the test server

Issue 3056 - [cms] Enable threading for the test server

[kzar, 2015-09-15 08:41:41]

https://codereview.adblockplus.org/29327611/diff/29327612/cms/bin/test_server.py
File cms/bin/test_server.py (right):

https://codereview.adblockplus.org/29327611/diff/29327612/cms/bin/test_server...
cms/bin/test_server.py:142: class ThreadedWSGIServer(ThreadingMixIn,
WSGIServer):
Perhaps we should set the daemon_threads attribute to True so that exiting the
server won't wait the 10 seconds for all these stalled connections to close?
(Not sure if there's an equivalent setting for the Werkzeug server?)

[Sebastian Noack, 2015-09-15 15:23:13]

https://codereview.adblockplus.org/29327611/diff/29327612/cms/bin/test_server.py
File cms/bin/test_server.py (right):

https://codereview.adblockplus.org/29327611/diff/29327612/cms/bin/test_server...
cms/bin/test_server.py:142: class ThreadedWSGIServer(ThreadingMixIn,
WSGIServer):
On 2015/09/15 08:41:41, kzar wrote:
> Perhaps we should set the daemon_threads attribute to True so that exiting the
> server won't wait the 10 seconds for all these stalled connections to close?
> (Not sure if there's an equivalent setting for the Werkzeug server?)

I agree that it would be preferable to have all threads terminate when the main
thread is terminated. In fact, during testing, I reproduced the server hanging
on Ctrl+C when there are still open connections.

However, to make werkzeug use daemon threads you either have to monkey-patch the
undocumented ThreadedWSGIServer class, or duplicate a fair amount of the code
from the run_simple function involving undocumented APIs as well.

I went for monkey patching for now, and submitted a pull request:
https://github.com/mitsuhiko/werkzeug/pull/770

[kzar, 2015-09-15 15:35:41]

LGTM

[Wladimir Palant, 2015-09-15 23:11:21]

LGTM