Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 29327712: Issue 3049 - Canonical URLs don't fallback to some browser languages (Closed)

Created:
Sept. 15, 2015, 3:22 p.m. by saroyanm
Modified:
Sept. 15, 2015, 4:01 p.m.
Reviewers:
Sebastian Noack, kzar
Visibility:
Public.

Description

Issue 3049 - Canonical URLs don't fallback to some browser languages

Patch Set 1 #

Patch Set 2 : rename pt_PT directory to pt #

Unified diffs Side-by-side diffs Delta from patch set Stats (+-100 lines, --100 lines) Patch
M locales/es/android-support/acceptable-ads-config.json View 0 chunks +-1 lines, --1 lines 0 comments Download
M locales/es/android-support/adding-filter-list.json View 0 chunks +-1 lines, --1 lines 0 comments Download
M locales/es/android-support/changing-language.json View 0 chunks +-1 lines, --1 lines 0 comments Download
M locales/es/android-support/customizing-abb.json View 0 chunks +-1 lines, --1 lines 0 comments Download
M locales/es/android-support/display-options.json View 0 chunks +-1 lines, --1 lines 0 comments Download
M locales/es/android-support/faq.json View 0 chunks +-1 lines, --1 lines 0 comments Download
M locales/es/android-support/index.json View 0 chunks +-1 lines, --1 lines 0 comments Download
M locales/es/android-support/install.json View 0 chunks +-1 lines, --1 lines 0 comments Download
M locales/es/android-support/privacy-options.json View 0 chunks +-1 lines, --1 lines 0 comments Download
M locales/es/android-support/removing-filter-list.json View 0 chunks +-1 lines, --1 lines 0 comments Download
M locales/es/header.json View 0 chunks +-1 lines, --1 lines 0 comments Download
M locales/es/images/badge-appstore.png View Binary file 0 comments Download
M locales/es/images/badge-playstore.png View Binary file 0 comments Download
M locales/es/index.json View 0 chunks +-1 lines, --1 lines 0 comments Download
M locales/es/ios-support/acceptable-ads-config.json View 0 chunks +-1 lines, --1 lines 0 comments Download
M locales/es/ios-support/adding-filter-list.json View 0 chunks +-1 lines, --1 lines 0 comments Download
M locales/es/ios-support/additional-filter-lists.json View 0 chunks +-1 lines, --1 lines 0 comments Download
M locales/es/ios-support/changing-search-engine.json View 0 chunks +-1 lines, --1 lines 0 comments Download
M locales/es/ios-support/disable-search-suggestions.json View 0 chunks +-1 lines, --1 lines 0 comments Download
M locales/es/ios-support/index.json View 0 chunks +-1 lines, --1 lines 0 comments Download
M locales/es/ios-support/install.json View 0 chunks +-1 lines, --1 lines 0 comments Download
M locales/es/ios-support/removing-filter-list.json View 0 chunks +-1 lines, --1 lines 0 comments Download
M locales/es/ios-support/view-whitelisted-websites.json View 0 chunks +-1 lines, --1 lines 0 comments Download
M locales/pt/android-support/acceptable-ads-config.json View 1 0 chunks +-1 lines, --1 lines 0 comments Download
M locales/pt/android-support/adding-filter-list.json View 1 0 chunks +-1 lines, --1 lines 0 comments Download
M locales/pt/android-support/changing-language.json View 1 0 chunks +-1 lines, --1 lines 0 comments Download
M locales/pt/android-support/customizing-abb.json View 1 0 chunks +-1 lines, --1 lines 0 comments Download
M locales/pt/android-support/display-options.json View 1 0 chunks +-1 lines, --1 lines 0 comments Download
M locales/pt/android-support/faq.json View 1 0 chunks +-1 lines, --1 lines 0 comments Download
M locales/pt/android-support/index.json View 1 0 chunks +-1 lines, --1 lines 0 comments Download
M locales/pt/android-support/install.json View 1 0 chunks +-1 lines, --1 lines 0 comments Download
M locales/pt/android-support/privacy-options.json View 1 0 chunks +-1 lines, --1 lines 0 comments Download
M locales/pt/android-support/removing-filter-list.json View 1 0 chunks +-1 lines, --1 lines 0 comments Download
M locales/pt/header.json View 1 0 chunks +-1 lines, --1 lines 0 comments Download
M locales/pt/images/badge-appstore.png View 1 Binary file 0 comments Download
M locales/pt/images/badge-playstore.png View 1 Binary file 0 comments Download
M locales/pt/index.json View 1 0 chunks +-1 lines, --1 lines 0 comments Download
M locales/pt/ios-support/acceptable-ads-config.json View 1 0 chunks +-1 lines, --1 lines 0 comments Download
M locales/pt/ios-support/adding-filter-list.json View 1 0 chunks +-1 lines, --1 lines 0 comments Download
M locales/pt/ios-support/additional-filter-lists.json View 1 0 chunks +-1 lines, --1 lines 0 comments Download
M locales/pt/ios-support/changing-search-engine.json View 1 0 chunks +-1 lines, --1 lines 0 comments Download
M locales/pt/ios-support/disable-search-suggestions.json View 1 0 chunks +-1 lines, --1 lines 0 comments Download
M locales/pt/ios-support/index.json View 1 0 chunks +-1 lines, --1 lines 0 comments Download
M locales/pt/ios-support/install.json View 1 0 chunks +-1 lines, --1 lines 0 comments Download
M locales/pt/ios-support/removing-filter-list.json View 1 0 chunks +-1 lines, --1 lines 0 comments Download
M locales/pt/ios-support/view-whitelisted-websites.json View 1 0 chunks +-1 lines, --1 lines 0 comments Download
M locales/pt_BR/android-support/acceptable-ads-config.json View 0 chunks +-1 lines, --1 lines 0 comments Download
M locales/pt_BR/android-support/adding-filter-list.json View 0 chunks +-1 lines, --1 lines 0 comments Download
M locales/pt_BR/android-support/changing-language.json View 0 chunks +-1 lines, --1 lines 0 comments Download
M locales/pt_BR/android-support/customizing-abb.json View 0 chunks +-1 lines, --1 lines 0 comments Download
M locales/pt_BR/android-support/display-options.json View 0 chunks +-1 lines, --1 lines 0 comments Download
M locales/pt_BR/android-support/faq.json View 0 chunks +-1 lines, --1 lines 0 comments Download
M locales/pt_BR/android-support/index.json View 0 chunks +-1 lines, --1 lines 0 comments Download
M locales/pt_BR/android-support/install.json View 0 chunks +-1 lines, --1 lines 0 comments Download
M locales/pt_BR/android-support/privacy-options.json View 0 chunks +-1 lines, --1 lines 0 comments Download
M locales/pt_BR/android-support/removing-filter-list.json View 0 chunks +-1 lines, --1 lines 0 comments Download
M locales/pt_BR/header.json View 0 chunks +-1 lines, --1 lines 0 comments Download
M locales/pt_BR/images/badge-appstore.png View Binary file 0 comments Download
M locales/pt_BR/images/badge-playstore.png View Binary file 0 comments Download
M locales/pt_BR/index.json View 0 chunks +-1 lines, --1 lines 0 comments Download
M locales/pt_BR/ios-support/acceptable-ads-config.json View 0 chunks +-1 lines, --1 lines 0 comments Download
M locales/pt_BR/ios-support/adding-filter-list.json View 0 chunks +-1 lines, --1 lines 0 comments Download
M locales/pt_BR/ios-support/additional-filter-lists.json View 0 chunks +-1 lines, --1 lines 0 comments Download
M locales/pt_BR/ios-support/changing-search-engine.json View 0 chunks +-1 lines, --1 lines 0 comments Download
M locales/pt_BR/ios-support/disable-search-suggestions.json View 0 chunks +-1 lines, --1 lines 0 comments Download
M locales/pt_BR/ios-support/index.json View 0 chunks +-1 lines, --1 lines 0 comments Download
M locales/pt_BR/ios-support/install.json View 0 chunks +-1 lines, --1 lines 0 comments Download
M locales/pt_BR/ios-support/removing-filter-list.json View 0 chunks +-1 lines, --1 lines 0 comments Download
M locales/pt_BR/ios-support/view-whitelisted-websites.json View 0 chunks +-1 lines, --1 lines 0 comments Download
M locales/zh_CN/android-support/acceptable-ads-config.json View 0 chunks +-1 lines, --1 lines 0 comments Download
M locales/zh_CN/android-support/adding-filter-list.json View 0 chunks +-1 lines, --1 lines 0 comments Download
M locales/zh_CN/android-support/changing-language.json View 0 chunks +-1 lines, --1 lines 0 comments Download
M locales/zh_CN/android-support/customizing-abb.json View 0 chunks +-1 lines, --1 lines 0 comments Download
M locales/zh_CN/android-support/display-options.json View 0 chunks +-1 lines, --1 lines 0 comments Download
M locales/zh_CN/android-support/faq.json View 0 chunks +-1 lines, --1 lines 0 comments Download
M locales/zh_CN/android-support/index.json View 0 chunks +-1 lines, --1 lines 0 comments Download
M locales/zh_CN/android-support/install.json View 0 chunks +-1 lines, --1 lines 0 comments Download
M locales/zh_CN/android-support/privacy-options.json View 0 chunks +-1 lines, --1 lines 0 comments Download
M locales/zh_CN/android-support/removing-filter-list.json View 0 chunks +-1 lines, --1 lines 0 comments Download
M locales/zh_CN/header.json View 0 chunks +-1 lines, --1 lines 0 comments Download
M locales/zh_CN/images/badge-appstore.png View Binary file 0 comments Download
M locales/zh_CN/images/badge-playstore.png View Binary file 0 comments Download
M locales/zh_CN/index.json View 0 chunks +-1 lines, --1 lines 0 comments Download
M locales/zh_CN/ios-support/acceptable-ads-config.json View 0 chunks +-1 lines, --1 lines 0 comments Download
M locales/zh_CN/ios-support/adding-filter-list.json View 0 chunks +-1 lines, --1 lines 0 comments Download
M locales/zh_CN/ios-support/additional-filter-lists.json View 0 chunks +-1 lines, --1 lines 0 comments Download
M locales/zh_CN/ios-support/changing-search-engine.json View 0 chunks +-1 lines, --1 lines 0 comments Download
M locales/zh_CN/ios-support/disable-search-suggestions.json View 0 chunks +-1 lines, --1 lines 0 comments Download
M locales/zh_CN/ios-support/index.json View 0 chunks +-1 lines, --1 lines 0 comments Download
M locales/zh_CN/ios-support/install.json View 0 chunks +-1 lines, --1 lines 0 comments Download
M locales/zh_CN/ios-support/removing-filter-list.json View 0 chunks +-1 lines, --1 lines 0 comments Download
M locales/zh_CN/ios-support/view-whitelisted-websites.json View 0 chunks +-1 lines, --1 lines 0 comments Download
M locales/zh_TW/android-support/acceptable-ads-config.json View 0 chunks +-1 lines, --1 lines 0 comments Download
M locales/zh_TW/android-support/adding-filter-list.json View 0 chunks +-1 lines, --1 lines 0 comments Download
M locales/zh_TW/android-support/changing-language.json View 0 chunks +-1 lines, --1 lines 0 comments Download
M locales/zh_TW/android-support/customizing-abb.json View 0 chunks +-1 lines, --1 lines 0 comments Download
M locales/zh_TW/android-support/display-options.json View 0 chunks +-1 lines, --1 lines 0 comments Download
M locales/zh_TW/android-support/faq.json View 0 chunks +-1 lines, --1 lines 0 comments Download
M locales/zh_TW/android-support/index.json View 0 chunks +-1 lines, --1 lines 0 comments Download
M locales/zh_TW/android-support/install.json View 0 chunks +-1 lines, --1 lines 0 comments Download
M locales/zh_TW/android-support/privacy-options.json View 0 chunks +-1 lines, --1 lines 0 comments Download
M locales/zh_TW/android-support/removing-filter-list.json View 0 chunks +-1 lines, --1 lines 0 comments Download
M locales/zh_TW/header.json View 0 chunks +-1 lines, --1 lines 0 comments Download
M locales/zh_TW/images/badge-appstore.png View Binary file 0 comments Download
M locales/zh_TW/images/badge-playstore.png View Binary file 0 comments Download
M locales/zh_TW/index.json View 0 chunks +-1 lines, --1 lines 0 comments Download
M locales/zh_TW/ios-support/acceptable-ads-config.json View 0 chunks +-1 lines, --1 lines 0 comments Download
M locales/zh_TW/ios-support/adding-filter-list.json View 0 chunks +-1 lines, --1 lines 0 comments Download
M locales/zh_TW/ios-support/additional-filter-lists.json View 0 chunks +-1 lines, --1 lines 0 comments Download
M locales/zh_TW/ios-support/changing-search-engine.json View 0 chunks +-1 lines, --1 lines 0 comments Download
M locales/zh_TW/ios-support/disable-search-suggestions.json View 0 chunks +-1 lines, --1 lines 0 comments Download
M locales/zh_TW/ios-support/index.json View 0 chunks +-1 lines, --1 lines 0 comments Download
M locales/zh_TW/ios-support/install.json View 0 chunks +-1 lines, --1 lines 0 comments Download
M locales/zh_TW/ios-support/removing-filter-list.json View 0 chunks +-1 lines, --1 lines 0 comments Download
M locales/zh_TW/ios-support/view-whitelisted-websites.json View 0 chunks +-1 lines, --1 lines 0 comments Download
M settings.ini View 1 3 chunks +5 lines, -5 lines 0 comments Download

Messages

Total messages: 5
saroyanm
@Dave can you please have a look.
Sept. 15, 2015, 3:26 p.m. (2015-09-15 15:26:20 UTC) #1
kzar
LGTM
Sept. 15, 2015, 3:33 p.m. (2015-09-15 15:33:26 UTC) #2
Sebastian Noack
As suggested in the ticket, I think we should simply use "pt" instead "pt_PT". Otherwise ...
Sept. 15, 2015, 3:36 p.m. (2015-09-15 15:36:10 UTC) #3
saroyanm
On 2015/09/15 15:36:10, Sebastian Noack wrote: > As suggested in the ticket, I think we ...
Sept. 15, 2015, 3:49 p.m. (2015-09-15 15:49:08 UTC) #4
Sebastian Noack
Sept. 15, 2015, 3:49 p.m. (2015-09-15 15:49:53 UTC) #5
LGTM

Powered by Google App Engine
This is Rietveld