Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 29328184: Issue 3092 - Support use of Jinja2 template inheritance (Closed)

Created:
Sept. 18, 2015, 11:06 a.m. by kzar
Modified:
Sept. 18, 2015, 2:07 p.m.
CC:
saroyanm
Visibility:
Public.

Description

Issue 3092 - Support use of Jinja2 template inheritance

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+53 lines, -13 lines) Patch
M README.md View 1 chunk +28 lines, -3 lines 0 comments Download
M cms/converters.py View 1 chunk +1 line, -1 line 1 comment Download
M cms/utils.py View 5 chunks +24 lines, -9 lines 0 comments Download

Messages

Total messages: 2
kzar
Patch Set 1
Sept. 18, 2015, 11:07 a.m. (2015-09-18 11:07:47 UTC) #1
Wladimir Palant
Sept. 18, 2015, 1:44 p.m. (2015-09-18 13:44:55 UTC) #2
Merely a nit below. I didn't go into the details because I generally disagree
with this solution - see my comment in the issue.

https://codereview.adblockplus.org/29328184/diff/29328185/cms/converters.py
File cms/converters.py (right):

https://codereview.adblockplus.org/29328184/diff/29328185/cms/converters.py#n...
cms/converters.py:273: if self._key == "pagedata" and not
self._params["jinja2_inheritence"]:
Nit: it's inheritance, not inheritence

Powered by Google App Engine
This is Rietveld