Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Unified Diff: chrome/content/ui/filters-search.js

Issue 29328828: Issue 3129/3144 - Fixed: Findbar key handling conflicted with filter editing (Closed)
Patch Set: Created Oct. 5, 2015, 10:21 a.m.
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/content/ui/filters-search.js
===================================================================
--- a/chrome/content/ui/filters-search.js
+++ b/chrome/content/ui/filters-search.js
@@ -50,6 +50,14 @@
// Hack to prevent "highlight all" from getting enabled
findbar.toggleHighlight = function() {};
+
+ // Ignore accessibility.typeaheadfind preference to avoid findbar
+ // being opened when interacting with filter tree
+ Object.defineProperty(findbar, "_findAsYouType", {
+ get: () => false,
+ enumerable: true,
+ configurable: true
+ });
Wladimir Palant 2015/10/05 14:17:20 I don't think we need to disable the functionality
Thomas Greiner 2015/10/05 16:45:20 Thanks for the link, I wasn't aware of this implem
},
/**
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld