Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Unified Diff: chrome/content/ui/filters-search.js

Issue 29328831: Issue 3144 - Fixed: Findbar opened when trying to enter / or ' in filter settings dialog (Closed)
Patch Set: Created Oct. 5, 2015, 10:27 a.m.
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/content/ui/filters-search.js
===================================================================
--- a/chrome/content/ui/filters-search.js
+++ b/chrome/content/ui/filters-search.js
@@ -253,7 +253,19 @@
return;
if (!("_ABPHandler" in listener))
- listener._ABPHandler = (event) => listener.receiveMessage(this._messageFromEvent(event));
+ {
+ listener._ABPHandler = (event) => {
+ if (event.type == "keypress")
+ {
+ let key = event.charCode ? String.fromCharCode(event.charCode) : null;
+ // Firefox manually triggers FAYT when ' or / is pressed
+ // so we need to capture those
+ if (key == "'" || key == "/")
+ return;
+ }
Wladimir Palant 2015/10/05 14:19:18 Please see https://codereview.adblockplus.org/2932
+ listener.receiveMessage(this._messageFromEvent(event));
+ };
+ }
E("filtersTree").addEventListener(this._messageMap[message], listener._ABPHandler, false);
},
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld