Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 29329031: Issue 3191 - Move filtermaster::repo_download to a distinct file (Closed)

Created:
Oct. 12, 2015, 9:35 a.m. by mathias
Modified:
Oct. 13, 2015, 11:44 a.m.
Reviewers:
Fred
CC:
Felix Dahlke
Visibility:
Public.

Description

Issue 3191 - Move filtermaster::repo_download to a distinct file

Patch Set 1 #

Total comments: 2

Patch Set 2 : Issue 3088 - Address feedback from codereview #

Unified diffs Side-by-side diffs Delta from patch set Stats (+36 lines, -13 lines) Patch
M modules/filtermaster/manifests/init.pp View 1 chunk +1 line, -13 lines 0 comments Download
A modules/filtermaster/manifests/repo_download.pp View 1 1 chunk +35 lines, -0 lines 0 comments Download

Messages

Total messages: 5
mathias
Oct. 12, 2015, 9:36 a.m. (2015-10-12 09:36:02 UTC) #1
mathias
Some points from my side upfront: https://codereview.adblockplus.org/29329031/diff/29329032/modules/filtermaster/manifests/repo_download.pp File modules/filtermaster/manifests/repo_download.pp (right): https://codereview.adblockplus.org/29329031/diff/29329032/modules/filtermaster/manifests/repo_download.pp#newcode23 modules/filtermaster/manifests/repo_download.pp:23: $repository = "https://hg.adblockplus.org/$title" ...
Oct. 12, 2015, 10 a.m. (2015-10-12 10:00:23 UTC) #2
Fred
> https://codereview.adblockplus.org/29329031/diff/29329032/modules/filtermaster/manifests/repo_download.pp#newcode27 > modules/filtermaster/manifests/repo_download.pp:27: exec {"fetch_${title}": > Maybe we should rename this part to be ...
Oct. 12, 2015, 12:49 p.m. (2015-10-12 12:49:51 UTC) #3
mathias
Oct. 12, 2015, 12:55 p.m. (2015-10-12 12:55:11 UTC) #4
mathias
Oct. 12, 2015, 1:32 p.m. (2015-10-12 13:32:06 UTC) #5

          

Powered by Google App Engine
This is Rietveld