Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 29329035: Issue 2975 - add spaces after colons on the settings page. (Closed)

Created:
Oct. 12, 2015, 10:07 a.m. by sergei
Modified:
Oct. 16, 2015, 7:37 a.m.
Reviewers:
Eric, Oleksandr
CC:
Felix Dahlke
Visibility:
Public.

Patch Set 1 #

Total comments: 3

Patch Set 2 : use &nbps; and fix patch order #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M html/templates/index.html View 1 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 6
sergei
Oct. 12, 2015, 10:08 a.m. (2015-10-12 10:08:47 UTC) #1
Eric
https://codereview.adblockplus.org/29329035/diff/29329036/html/templates/index.html File html/templates/index.html (left): https://codereview.adblockplus.org/29329035/diff/29329036/html/templates/index.html#oldcode33 html/templates/index.html:33: <span id="localeLanguageLabel" class="feature-title">Language:</span><span class="feature-title"> </span><span id="localeLanguageDescription" class="feature-title">Select your language ...
Oct. 13, 2015, 5:08 p.m. (2015-10-13 17:08:10 UTC) #2
Oleksandr
https://codereview.adblockplus.org/29329035/diff/29329036/html/templates/index.html File html/templates/index.html (left): https://codereview.adblockplus.org/29329035/diff/29329036/html/templates/index.html#oldcode33 html/templates/index.html:33: <span id="localeLanguageLabel" class="feature-title">Language:</span><span class="feature-title"> </span><span id="localeLanguageDescription" class="feature-title">Select your language ...
Oct. 15, 2015, 11:04 a.m. (2015-10-15 11:04:06 UTC) #3
sergei
https://codereview.adblockplus.org/29329035/diff/29329036/html/templates/index.html File html/templates/index.html (left): https://codereview.adblockplus.org/29329035/diff/29329036/html/templates/index.html#oldcode33 html/templates/index.html:33: <span id="localeLanguageLabel" class="feature-title">Language:</span><span class="feature-title"> </span><span id="localeLanguageDescription" class="feature-title">Select your language ...
Oct. 15, 2015, 11:15 a.m. (2015-10-15 11:15:52 UTC) #4
Oleksandr
LGTM
Oct. 15, 2015, 11:49 a.m. (2015-10-15 11:49:27 UTC) #5
Eric
Oct. 15, 2015, 3:34 p.m. (2015-10-15 15:34:18 UTC) #6
LGTM

Powered by Google App Engine
This is Rietveld