Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(161)

Issue 29329095: Issue 2747 - Added empty state for tables in options page (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
4 years ago by Thomas Greiner
Modified:
3 years, 10 months ago
Reviewers:
saroyanm
Visibility:
Public.

Description

This review also contains the following minor changes: - Fixed: Saving empty custom filters box produced a filter with the text "" - Added empty states for other tables (where appropriate) - Added placeholder to whitelist domain input field - Used `index` in `Collection.removeItem` for selecting list element - Properly reset items list in `Collection.clearAll` instead of overwriting its `length` attribute - Miscellaneous whitespace corrections

Patch Set 1 #

Total comments: 5

Patch Set 2 : Rebased to 41fbae6c0e66 #

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+78 lines, -22 lines) Patch
M background.js View 1 1 chunk +3 lines, -1 line 0 comments Download
M locale/en-US/options.json View 1 2 3 chunks +20 lines, -0 lines 0 comments Download
M options.html View 1 2 1 chunk +5 lines, -1 line 0 comments Download
M options.js View 1 8 chunks +41 lines, -14 lines 0 comments Download
M skin/options.css View 2 chunks +9 lines, -6 lines 0 comments Download

Messages

Total messages: 4
Thomas Greiner
4 years ago (2015-10-13 14:30:49 UTC) #1
saroyanm
https://codereview.adblockplus.org/29329095/diff/29329096/background.js File background.js (right): https://codereview.adblockplus.org/29329095/diff/29329096/background.js#newcode180 background.js:180: .filter(function(filter) {return !!filter;}) nice. https://codereview.adblockplus.org/29329095/diff/29329096/options.html File options.html (right): https://codereview.adblockplus.org/29329095/diff/29329096/options.html#newcode193 ...
3 years, 10 months ago (2015-11-30 11:24:22 UTC) #2
Thomas Greiner
https://codereview.adblockplus.org/29329095/diff/29329096/options.html File options.html (right): https://codereview.adblockplus.org/29329095/diff/29329096/options.html#newcode193 options.html:193: <span>Test</span> On 2015/11/30 11:24:21, saroyanm wrote: > Please change ...
3 years, 10 months ago (2015-12-11 16:49:35 UTC) #3
saroyanm
3 years, 10 months ago (2015-12-17 15:51:21 UTC) #4
LGTM
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 87257f5