Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(77)

Issue 29329159: Issue #1185 - Fix formatting in installer-lib and its tests (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
4 years, 1 month ago by Eric
Modified:
4 years ago
Reviewers:
Oleksandr
CC:
Felix Dahlke
Visibility:
Public.

Description

Issue #1185 - Fix formatting in installer-lib and its tests This is a format-only change, changing mostly only whitespace. In a few cases some curly braces were added. Also removed some tabs in the custom action code that were previously overlooked.

Patch Set 1 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1068 lines, -1009 lines) Patch
M installer/src/custom-action/abp_ca.rc View 1 chunk +6 lines, -6 lines 0 comments Download
M installer/src/custom-action/close_application.cpp View 1 chunk +1 line, -1 line 0 comments Download
M installer/src/installer-lib/DLL.h View 3 chunks +5 lines, -5 lines 0 comments Download
M installer/src/installer-lib/DLL.cpp View 2 chunks +19 lines, -17 lines 0 comments Download
M installer/src/installer-lib/custom-i18n.h View 1 chunk +16 lines, -15 lines 0 comments Download
M installer/src/installer-lib/database.h View 7 chunks +33 lines, -33 lines 0 comments Download
M installer/src/installer-lib/database.cpp View 3 chunks +31 lines, -31 lines 0 comments Download
M installer/src/installer-lib/handle.h View 13 chunks +82 lines, -63 lines 0 comments Download
M installer/src/installer-lib/installer-lib.h View 3 chunks +33 lines, -33 lines 0 comments Download
M installer/src/installer-lib/interaction.h View 5 chunks +21 lines, -21 lines 0 comments Download
M installer/src/installer-lib/interaction.cpp View 1 chunk +14 lines, -14 lines 0 comments Download
M installer/src/installer-lib/process.h View 22 chunks +176 lines, -161 lines 0 comments Download
M installer/src/installer-lib/process.cpp View 7 chunks +124 lines, -106 lines 0 comments Download
M installer/src/installer-lib/property.h View 9 chunks +16 lines, -16 lines 0 comments Download
M installer/src/installer-lib/property.cpp View 3 chunks +25 lines, -25 lines 0 comments Download
M installer/src/installer-lib/record.h View 11 chunks +55 lines, -51 lines 0 comments Download
M installer/src/installer-lib/record.cpp View 1 chunk +26 lines, -26 lines 0 comments Download
M installer/src/installer-lib/session.h View 10 chunks +27 lines, -26 lines 0 comments Download
M installer/src/installer-lib/session.cpp View 2 chunks +33 lines, -33 lines 0 comments Download
M installer/src/installer-lib/test/custom-action-fail.cpp View 1 chunk +6 lines, -6 lines 0 comments Download
M installer/src/installer-lib/test/database_test.cpp View 1 chunk +37 lines, -37 lines 0 comments Download
M installer/src/installer-lib/test/exception_test.cpp View 1 chunk +28 lines, -28 lines 0 comments Download
M installer/src/installer-lib/test/process_test.cpp View 4 chunks +139 lines, -139 lines 0 comments Download
M installer/src/installer-lib/test/property_test.cpp View 2 chunks +12 lines, -12 lines 0 comments Download
M installer/src/installer-lib/test/record_test.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M installer/src/installer-lib/test/test-installer-lib-ca.cpp View 2 chunks +41 lines, -41 lines 0 comments Download
M installer/src/installer-lib/test/test-installer-lib-ca.rc View 1 chunk +6 lines, -6 lines 0 comments Download
M installer/src/installer-lib/test/test-installer-lib-sandbox.cpp View 2 chunks +54 lines, -55 lines 0 comments Download

Messages

Total messages: 2
Eric
FYI. I used Artistic Style to perform much of this reformatting. There's now a Visual ...
4 years, 1 month ago (2015-10-15 19:08:39 UTC) #1
Oleksandr
4 years ago (2015-10-21 10:58:22 UTC) #2
LGTM. Great plugin too. We should probably have all C++ contributors using it.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 87257f5