Issue 29329404: Issue 443 - Fix blocking pop-ups after redirect

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 29329404: Issue 443 - Fix blocking pop-ups after redirect (Closed)

Created:
Oct. 26, 2015, 8:28 p.m. by Wladimir Palant

Modified:
Nov. 6, 2015, 8:05 p.m.

Reviewers:
Thomas Greiner, tschuster

Visibility:
Public.

Description

The current code will merely prevent the redirect, not close the pop-up.

Patch Set 2 : Made sure to look at the original channel as well #

Total comments: 2

Patch Set 3 : Improved comment #

Created: Nov. 5, 2015, 3:51 p.m.

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+12 lines, -12 lines)			Patch
	M	lib/contentPolicy.js	View	1 2	1 chunk	+12 lines, -12 lines	0 comments	Download

Messages

Total messages: 6

Expand All Messages | Collapse All Messages

Wladimir Palant

https://codereview.adblockplus.org/29329404/diff/29329405/lib/contentPolicy.js File lib/contentPolicy.js (right): https://codereview.adblockplus.org/29329404/diff/29329405/lib/contentPolicy.js#newcode554 lib/contentPolicy.js:554: if (contentType == Ci.nsIContentPolicy.TYPE_DOCUMENT) This relies on the changes ...

Oct. 26, 2015, 8:50 p.m. (2015-10-26 20:50:26 UTC) #2

Wladimir Palant

With the new patchset all the pop-up blocking unit tests are passing now (at least ...

Oct. 27, 2015, 1:30 p.m. (2015-10-27 13:30:49 UTC) #3

tschuster

LGTM https://codereview.adblockplus.org/29329404/diff/29329417/lib/contentPolicy.js File lib/contentPolicy.js (right): https://codereview.adblockplus.org/29329404/diff/29329417/lib/contentPolicy.js#newcode512 lib/contentPolicy.js:512: } I think your comment about this patch ...

Nov. 5, 2015, 3:27 p.m. (2015-11-05 15:27:19 UTC) #4

Wladimir Palant

Note that interdiff will show further changes beyond the comment - these are due to ...

Nov. 5, 2015, 3:51 p.m. (2015-11-05 15:51:59 UTC) #5

tschuster

Nov. 6, 2015, 8 p.m. (2015-11-06 20:00:23 UTC) #6

On 2015/11/05 15:51:59, Wladimir Palant wrote:
> Note that interdiff will show further changes beyond the comment - these are
due
> to rebasing.
> 
> https://codereview.adblockplus.org/29329404/diff/29329417/lib/contentPolicy.js
> File lib/contentPolicy.js (right):
> 
>
https://codereview.adblockplus.org/29329404/diff/29329417/lib/contentPolicy.j...
> lib/contentPolicy.js:512: }
> On 2015/11/05 15:27:18, tschuster wrote:
> > I think your comment about this patch set would help here.
> > // The normal code below will merely prevent the redirect, not close the
> pop-up.
> 
> Done.

LGTM

Expand All Messages | Collapse All Messages