Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 29329409: Issue 3208 - Don`t keep track of content policy for redirects, Gecko will do that for us (Closed)

Created:
Oct. 26, 2015, 8:37 p.m. by Wladimir Palant
Modified:
Nov. 4, 2015, 3:12 p.m.
Visibility:
Public.

Description

Issue 3208 - Don`t keep track of content policy for redirects, Gecko will do that for us

Patch Set 1 #

Total comments: 2

Patch Set 2 : Explicitly check for property existance #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -47 lines) Patch
M lib/contentPolicy.js View 1 3 chunks +7 lines, -47 lines 0 comments Download

Messages

Total messages: 4
Wladimir Palant
Oct. 26, 2015, 8:37 p.m. (2015-10-26 20:37:51 UTC) #1
tschuster
LGTM This is a really nice change, the previousRequest business was kind of sad. https://codereview.adblockplus.org/29329409/diff/29329410/lib/contentPolicy.js ...
Oct. 29, 2015, 2:02 p.m. (2015-10-29 14:02:03 UTC) #2
Wladimir Palant
Note that the unrelated changes in the interdiff are due to rebasing. https://codereview.adblockplus.org/29329409/diff/29329410/lib/contentPolicy.js File lib/contentPolicy.js ...
Oct. 29, 2015, 6:22 p.m. (2015-10-29 18:22:48 UTC) #3
Thomas Greiner
Nov. 2, 2015, 2:26 p.m. (2015-11-02 14:26:28 UTC) #4
LGTM

Powered by Google App Engine
This is Rietveld