Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 29329467: Issue 3208 - Minor consistency fixes (Closed)

Created:
Oct. 29, 2015, 1:03 p.m. by Wladimir Palant
Modified:
Nov. 3, 2015, 10:49 a.m.
Visibility:
Public.

Description

This enables strict mode, fixes the imports and turns whitelistedSchemes into a Set.

Patch Set 1 #

Total comments: 2

Patch Set 2 : Updated JSDoc comment #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -7 lines) Patch
M lib/contentPolicy.js View 1 4 chunks +9 lines, -7 lines 1 comment Download

Messages

Total messages: 4
Wladimir Palant
Oct. 29, 2015, 1:03 p.m. (2015-10-29 13:03:20 UTC) #1
tschuster
LGTM https://codereview.adblockplus.org/29329467/diff/29329468/lib/contentPolicy.js File lib/contentPolicy.js (right): https://codereview.adblockplus.org/29329467/diff/29329468/lib/contentPolicy.js#newcode80 lib/contentPolicy.js:80: * @type Object @type Set
Oct. 29, 2015, 1:23 p.m. (2015-10-29 13:23:22 UTC) #2
Wladimir Palant
https://codereview.adblockplus.org/29329467/diff/29329468/lib/contentPolicy.js File lib/contentPolicy.js (right): https://codereview.adblockplus.org/29329467/diff/29329468/lib/contentPolicy.js#newcode80 lib/contentPolicy.js:80: * @type Object On 2015/10/29 13:23:22, tschuster wrote: > ...
Oct. 29, 2015, 6:17 p.m. (2015-10-29 18:17:23 UTC) #3
Thomas Greiner
Nov. 2, 2015, 2:09 p.m. (2015-11-02 14:09:03 UTC) #4
LGTM

https://codereview.adblockplus.org/29329467/diff/29329495/lib/contentPolicy.js
File lib/contentPolicy.js (right):

https://codereview.adblockplus.org/29329467/diff/29329495/lib/contentPolicy.j...
lib/contentPolicy.js:263: * @param location  {nsIURI}
Detail: That line's in wrong order. It should be `{type} name` instead of `name 
{type}`.

Powered by Google App Engine
This is Rietveld