Issue 3208 - Make Policy.processNode() accept plain strings instead of nsIURI

Issue 3208 - Make Policy.processNode() accept plain strings instead of nsIURI

[tschuster, 2015-10-31 11:55:24]

https://codereview.adblockplus.org/29329470/diff/29329471/lib/contentPolicy.js
File lib/contentPolicy.js (right):

https://codereview.adblockplus.org/29329470/diff/29329471/lib/contentPolicy.j...
lib/contentPolicy.js:213: location = match.text.replace(/^.*?#/, '#');
Wait, how does this work? 
On the right hand side match is location and location is a String. So match.text
is just undefined?

[Wladimir Palant, 2015-11-01 12:18:10]

https://codereview.adblockplus.org/29329470/diff/29329471/lib/contentPolicy.js
File lib/contentPolicy.js (right):

https://codereview.adblockplus.org/29329470/diff/29329471/lib/contentPolicy.j...
lib/contentPolicy.js:213: location = match.text.replace(/^.*?#/, '#');
On 2015/10/31 11:55:23, tschuster wrote:
> Wait, how does this work? 
> On the right hand side match is location and location is a String. So
match.text
> is just undefined?

Yes, this is quite a hack. Calls with content type ELEMHIDE come from elemHide
module rather than the content policy. Since those don't really have a location
associated with them, a Filter instance is being passed in as location
parameter. In https://issues.adblockplus.org/ticket/3251 we should make it a
little less hacky - location will be a key extracted from the elemhide channel
URI, and the code here will resolve it into a filter.

[tschuster, 2015-11-05 15:35:07]

On 2015/11/01 12:18:10, Wladimir Palant wrote:
> https://codereview.adblockplus.org/29329470/diff/29329471/lib/contentPolicy.js
> File lib/contentPolicy.js (right):
> 
>
https://codereview.adblockplus.org/29329470/diff/29329471/lib/contentPolicy.j...
> lib/contentPolicy.js:213: location = match.text.replace(/^.*?#/, '#');
> On 2015/10/31 11:55:23, tschuster wrote:
> > Wait, how does this work? 
> > On the right hand side match is location and location is a String. So
> match.text
> > is just undefined?
> 
> Yes, this is quite a hack. Calls with content type ELEMHIDE come from elemHide
> module rather than the content policy. Since those don't really have a
location
> associated with them, a Filter instance is being passed in as location
> parameter. In https://issues.adblockplus.org/ticket/3251 we should make it a
> little less hacky - location will be a key extracted from the elemhide channel
> URI, and the code here will resolve it into a filter.

Okay, good to know it is going to be fixed.
LGTM

[Thomas Greiner, 2015-11-10 10:24:31]

LGTM